Opened 3 years ago
Closed 3 years ago
#1078 closed defect (fixed)
[C API] GEOSCoordSeq_setOrdinate no longer returns error code
Reported by: | jorisvandenbossche | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 3.9.0 |
Component: | Default | Version: | main |
Severity: | Unassigned | Keywords: | |
Cc: |
Description
When trying to set an ordinate for a non-existing dimension, the C function no longer returns the correct error return value.
See https://github.com/pygeos/pygeos/issues/233#issuecomment-723860368 for context
This seems to stem from a small mistake in the refactor in https://github.com/libgeos/geos/commit/8e29f768e6d8597a5568acd628712583506f9928, which accidentally changed the error return value for GEOSCoordSeq_setOrdinate_r
from 0 to 1, so we no longer catch the error.
I further checked the rest of the file, but I think this is the only case of a wrong return code.
(will open a PR with fix shortly)