Opened 18 years ago

Last modified 15 years ago

#100 closed defect (fixed)

Private ctors problem in Simplify

Reported by: mloskot Owned by: strk@…
Priority: major Milestone:
Component: Core Version: main
Severity: Significant Keywords: imported, phpbugtracker
Cc:

Description (last modified by mloskot)

Yesterday, nhv and hobu reported that GEOS does not compile because of problem with private ctors in classes from simplify package.

​http://logs.qgis.org/postgis/%23postgis.2006-04-21.log

As I explained them, I'm not sure about design decisions, so I don't know if those ctors should be moved to public section or the code using those ctors should be changed.

Nevertheless, I decided to apply temporary fix. I've committed those changes to CVS as well, accordint to the rule to have GEOS in CVS compilable.

I also attached patch to this bug report, but only to make it easier to see what changes I applied. 

$ cd geos
$ cvs diff -U2 > my.patch

Attachments (1)

simplify-private-ctors-temp-sln-mloskot-20060422.patch​ (1.7 KB ) - added by mateusz@… 18 years ago.

Download all attachments as: .zip

Change History (4)

by mateusz@…, 18 years ago

Attachment: simplify-private-ctors-temp-sln-mloskot-20060422.patch​ added

comment:1 by strk@…, 18 years ago

Resolution: none → fixed 
Made the change permanent, as far as the helper classes
are only visible within the .cpp file there's no problem with an all public class

comment:2 by mloskot, 17 years ago

Description: modified (diff)
Milestone: imported → 3.0.0
Priority: 4 → major
Reporter: changed from mateusz@… to mloskot
Severity: Critical → Significant
Version: 3.0.0 → svn-trunk

comment:3 by (none), 15 years ago

Milestone: 3.0.0

Milestone 3.0.0 deleted

Note: See TracTickets for help on using tickets.