Opened 15 years ago

Last modified 13 years ago

#40 closed enhancement

Widget that are missing template information — at Version 2

Reported by: woodbri Owned by:
Priority: minor Milestone: Future
Component: widgets Version:
Keywords: Cc:

Description (last modified by adube)

In general it would be very helpful if Geoprisma better handled widgets with respect to including appropriate template fragments needed. For example, if you include a GYMO layer and do not have the appropriate stuff in the template it fails with a meaningless javascript error.

It would be nice if the widget docs made these requirements more explicit, or better yet if including the widget in your project it would automagically add any required template fragments into your template.

For the resultextgrid, on the contrary, the code in core should definitively be moved from there at some point.

This could be a doc or widget defect/enhancement.

Change History (2)

comment:1 by adube, 14 years ago

I agree. If any API key is required by layers for example, it should read by the widget creating the layers (Map and Layer) and include them, in the 'printWidgetSource' template for instance.

For other widgets requiring manual includes, the only one I can think of is the ResultExtGrid widget. It requires the js inside the core. Since it's the only widget that does that and there won't be any other widget using these files, I propose we move all these files inside the ResultExtGrid widget in make it include them. I think there's one that should remain (the Util one I think).

If we don't want to move these, at least we could have them always included by Globals.xslt or something...

comment:2 by adube, 13 years ago

Component: documentationwidgets
Description: modified (diff)
Milestone: Future
Priority: majorminor
Type: defectenhancement

I've changed my mind with time. I think it's better to let the template (100% customized by user) to handle most the inclusions needed by widgets, including external libraries and such. The auto-including logic for printWidgetSource templates sometimes becomes a problem because the code is never compressed.

We could have something to handle including widget code for 'dev' purpose, but for the rest it should be controlled by the user.

I'm moving this to 'Future' until we think that is becoming an issue at some point.

Note: See TracTickets for help on using tickets.