Opened 12 years ago

Last modified 12 years ago

#357 new defect

WFSFilterBuilder - search field broke grid after too many request

Reported by: cdeschenes Owned by: belug
Priority: major Milestone: 1.8.0
Component: widgets Version: trunk
Keywords: WFSFilterBuilder, seach, delay, request, field Cc: adube

Description

When user do search in WFSFilterBuilder results tab, the list stop respond when user change search field when another search request is already pending. After this, there is nothing to do to repair this.

Possible solutions

  • Increase delay after key press to send request (currently hardcoded to 300 in Ext.ux.grd.Search componement)
  • set Search field disabled when request is already pending.

Attachments (6)

patch-wfsfilterbuilder-searchfield-357-r1177-A0.diff (793 bytes ) - added by cdeschenes 12 years ago.
A fix disabling search fields during requests
patch-wfsfilterbuilder-searchfield-357-r1177-A1.diff (5.8 KB ) - added by cdeschenes 12 years ago.
Another fix
patch-wfsfilterbuilder-searchfield-357-r1177-A2.diff (5.7 KB ) - added by cdeschenes 12 years ago.
I forget a debug code in revision A1
patch-wfsfilterbuilder-searchfield-357-r1205-A3.diff (5.7 KB ) - added by cdeschenes 12 years ago.
Update of the fix
patch-wfsfilterbuilder-searchfield-357-r1206-A4.diff (6.0 KB ) - added by adube 12 years ago.
Same fix, property name changed, minor corrections
patch-wfsfilterbuilder-searchfield-357-r1217-A5.diff (6.0 KB ) - added by cdeschenes 12 years ago.
Fix for cursor (disabled replaced by readonly state)

Download all attachments as: .zip

Change History (17)

by cdeschenes, 12 years ago

A fix disabling search fields during requests

comment:1 by cdeschenes, 12 years ago

Finally I will post bether fix soon

by cdeschenes, 12 years ago

Another fix

by cdeschenes, 12 years ago

I forget a debug code in revision A1

by cdeschenes, 12 years ago

Update of the fix

comment:2 by cdeschenes, 12 years ago

Please review

comment:3 by cdeschenes, 12 years ago

Please review

by adube, 12 years ago

Same fix, property name changed, minor corrections

comment:4 by adube, 12 years ago

cdeschenes, here's an updated version of your patch with the following minor fixes :

  • property "renderDelay" renamed "triggerDelay"
  • English corrections

issue : I noticed that the patch introduces a small bug. When disabling the search text field, the cursor disappear. Clicking in it doesn't bring it back. Please make the according fixes.

by cdeschenes, 12 years ago

Fix for cursor (disabled replaced by readonly state)

comment:5 by cdeschenes, 12 years ago

Please review

comment:6 by adube, 12 years ago

Resolution: fixed
Status: newclosed

Fixed in r1223, p=cdeschenes r=me.

comment:7 by adube, 12 years ago

Resolution: fixed
Status: closedreopened
Version: trunk

The fix doesn't work in IE.

comment:8 by adube, 12 years ago

In IE, while the query is in progress and the search text field gets grayed out, you can still enter characters using the keyboard, thus launching more requests.

comment:9 by adube, 12 years ago

Milestone: 1.2.01.4.0

No patch : pushed to 1.4 since the widget is still considered unstable.

comment:10 by adube, 12 years ago

Milestone: 1.4.01.6.0

No patch, pushed to 1.6.

comment:11 by adube, 12 years ago

Milestone: 1.6.01.8.0
Owner: changed from cdeschenes to belug
Status: reopenednew

The proposed fix is still incomplete. I'm pushing this to 1.8 and reassigning it to belug.

Note: See TracTickets for help on using tickets.