Opened 13 years ago

Closed 13 years ago

#334 closed defect (fixed)

WFSFilterBuilder - zoomToFeature js error

Reported by: cdeschenes Owned by: adube
Priority: major Milestone: 1.2.0
Component: widgets Version:
Keywords: Cc: adube

Description (last modified by adube)

Issue

When the WFSFilterBuilder widget isn't linked to a QueryOnClick widget, zooming on a feature (with the zoom button in the result grid) throws a javascript error. This is caused because it uses the feature.layer.map to access the map.

Solution

The map object is already available in the FilterButton, so it could be used when creating the result grid as an API property.

Attachments (4)

FeatureGridResult.patch (651 bytes ) - added by cdeschenes 13 years ago.
execute in .\src\client\widgets\wfsfilterbuilder
FeatureGridResult.2.patch (1.4 KB ) - added by cdeschenes 13 years ago.
A new patch
FeatureGridResult.3.patch (1.4 KB ) - added by cdeschenes 13 years ago.
Better comment
patch-wfsfilterbuilder-zoomtofix-334-r1166-A3.diff (1.8 KB ) - added by cdeschenes 13 years ago.
New valid patch

Download all attachments as: .zip

Change History (7)

by cdeschenes, 13 years ago

Attachment: FeatureGridResult.patch added

execute in .\src\client\widgets\wfsfilterbuilder

comment:1 by adube, 13 years ago

Component: documentationwidgets
Description: modified (diff)
Keywords: filterBuilder js zoom error removed
Milestone: 1.0.01.2.0
Priority: minormajor
Summary: no layer cause error when click on "zoom on feature" button in wfsfilterbuilderWFSFilterBuilder - zoomToFeature js error
Type: enhancementdefect
Version: 1.0

comment:2 by adube, 13 years ago

The patch is not valid. 'map' can't be used as a global variable, it has to be set as an API property of the result grid using the one in the filter button.

by cdeschenes, 13 years ago

Attachment: FeatureGridResult.2.patch added

A new patch

by cdeschenes, 13 years ago

Attachment: FeatureGridResult.3.patch added

Better comment

by cdeschenes, 13 years ago

New valid patch

comment:3 by adube, 13 years ago

Resolution: fixed
Status: newclosed

Fixed in r1167, thanks for the patch.

Note: See TracTickets for help on using tickets.