Opened 13 years ago
Closed 13 years ago
#303 closed defect (fixed)
WFSFilterBuilder - bug - can clear filters without selection
Reported by: | adube | Owned by: | fgagnon |
---|---|---|---|
Priority: | minor | Milestone: | 1.0.0 |
Component: | widgets | Version: | |
Keywords: | Cc: |
Description ¶
Issue
In the WFSFilterBuilder widget, it is possible to click the "clear filters" button when no layer is selected yet, which triggers a request.
Solutions
We could do one of the following :
- Disable the button until we select something.
- Do the above, plus : enable/disable the button when a new filter was applied or reset
- Check if a layer is selected before clearing
Any more thoughts are welcome.
Change History (3)
by , 13 years ago
Attachment: | 303_fixes.diff added |
---|
comment:1 by , 13 years ago
This patch disable the "Reset all filters" button until a layer is selected, preventing an invalid (and unnecessary) request.
Enabling and disabling the button depending on filters statuses is error-prone due to diversing sources and behavior of the multiple filters controls, thus this was ommited. However, if this is a concern, there should be no technical barrier to accomplish this.
comment:2 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
The patch works for me. Commit in r1153.
This patch disable the reset filters button on startup