WFSFilterBuilder - Clear filter

[fgagnon]

Since the filter built is kept in memory when you close the window, adding a button to reset the FilterBuilder (and empty the search textfield of the result panel) would be useful.

[fgagnon]

added a 'Remove all' button on top of the FilterBuilder, clearing all filters

[adube]

Here's a review of this patch :

• The button resets both FilterBuilder components (on the left) and the search textfield (on the right). I think it would be more appropriate to have it accessible from both tabs, thus positioning it in the top toolbar, next to the layer list.
• if we do that, its label could be rename from "Remove all" to "Reset all filters"
• I think it should trigger a new request upon click as well. Currently, clicking resets everything but the result grid, which is odd. In doubt, we could have an flag option for that.

[fgagnon]

This patch apply all suggestions

[fgagnon]

The latest patch moved the new button to main toolbar beside the layer selector. The label was renamed as well.

In addition, it now triggers a new request correctly upon click. Previously, it only did so when the result panel (with the grid.Search) was active. As a side effect, this also fix an unreported bug where the search textfield was not cleared when the layer was changed, despite its associated filter being reset.

Additional testing is highly recommended.

[adube]

Fixed in r1144.