Opened 12 years ago

Closed 12 years ago

#921 closed defect (fixed)

geonetwork won't undeploy/shutdown in tomcat due to quartz scheduler threads

Reported by: simonp Owned by: jesseeichar
Priority: major Milestone: v2.7.0
Component: General Version:
Keywords: Cc:

Description

Seems that quartz scheduler threads don't get shutdown maybe because they are called in a finalize method of the HarvestManager and these aren't guaranteed to get called when the JVM shuts down (see for example https://www.securecoding.cert.org/confluence/display/java/MET12-J.+Do+not+use+finalizers) - moving the HarvestManager shutdown process to the stop() method of web/src/main/java/org/fao/geonet/GeoNetwork.java fixes the problem and tomcat can then undeploy/stop the webapp - small patch attached

Attachments (1)

shutdown.patch (3.3 KB ) - added by simonp 12 years ago.

Download all attachments as: .zip

Change History (3)

by simonp, 12 years ago

Attachment: shutdown.patch added

comment:1 by jesseeichar, 12 years ago

Owner: changed from geonetwork-devel@… to jesseeichar

Fix looks good to me. I have applied it to trunk and will apply it to 2.8 branch as well as soon as I can check that out.

comment:2 by jesseeichar, 12 years ago

Resolution: fixed
Status: newclosed

committed to 2.8.x branch as well

Note: See TracTickets for help on using tickets.