Duplication of Javascript functions

[justinrowles]

doTabAction (for example) is defined in both metadata-editor.js and metadata-view.js.

When the package process runs, it combines both of these into gn.editor.js, which means whatever is in metadata-editor.js is effectively overwritten.

[justinrowles]

Oops: metadata-show, not metadata-view.

[justinrowles]

This, incidentally, is why the screen doesn't get disabled when switching tabs in edit mode. The version in metadata-show doesn't include the disableEditForm call.

[justinrowles]

Oh. And it's also defined in remote-show.xsl

[justinrowles]

The same problem occurs with doAction for example.

I'm marking this as critical as I think compiling metadata-editor and metadata-show together into gn.editor.js is silently breaking things (in this case the setBunload functionality).