'???' added to 'sources' table on single/multiple XML file import

[awalsh]

Using GN 2.6.3 a '???' is added to the 'name' column of the 'sources' table whenever a single XML file or multiple XML (batch) file import is done. It appears to be because the source XML file has no siteName so the program inserts a '???' instead for the name column and the local siteID (uuid) into the uuid column. The side effect of this bug is that a '???' appears on the Advanced Search->Restrict To->Catalog drop down list which is confusing as this list will already an entry containing the local siteName.

I shown this issue to Craig Jones a BlueNet Geonetwork developer in Australia. Craig has kindly written a patch (attached) to fix this issue. The patch has been tested and it works with the BlueNet Geonetwork.

I have also tested other import cases of XML copy/paste, MEF file upload: single/multiple and MEF file upload from another siteID. For these other import cases the local siteID and local siteName are added to the sources table except in the case of a MEF file from another siteID in which the other siteID and siteName is added.

Finally a comment about the sources table. Looking at the way the table is used it makes my wonder why we need to be adding entries to the sources table from 'local' sources. I would have thought that the sources table was supposed to show 'non-local' sources such as harvests from other sites of harvest uuid's.

[awalsh]

Patch for trunk

[simonp]

Fixed in svn rev 7321 for 2.6.x and 7320 for trunk