Opened 12 years ago

Closed 12 years ago

#133 closed defect (fixed)

Demo uses "legend=" rather than "show-legend="

Reported by: osjonathan Owned by: theduckylittle
Priority: minor Milestone: 2.6.1
Component: Docs Version: 2.6
Keywords: Cc: EliL

Description

In the Demo mapbook that comes with the default install, the "ArcGIS 9.3 Rest example" seems to load a huge image in the layer-menu on the left.

The two USGS backgrounds also appear to try to do this but fail with a "image not found" X (IE) instead.

Change History (10)

comment:1 by osjonathan, 12 years ago

Component: BuildToolsDemo
Summary: ArcGIS 9.3 Rest example in Demo issueDemo uses "legend=" rather than "show-legend="

The demo mapbook uses: legend="false" to try and disable the legend, not just for this but for other things too. I almost reported as a bug that GM ignored this setting, however according to the documentation (http://www.geomoose.org/docs/mapbook.html), it should be show-legend="false"

There are 18 instances of legend= in the demo mapbook (which therefore don't work), but only one of show-legend=

This will probably confuse new users who learn by copying (i.e. me!).

comment:2 by theduckylittle, 12 years ago

Status: newtesting

Removed the old style "legend="'s, r880

comment:3 by theduckylittle, 12 years ago

Milestone: 2.6.1
Status: testingneeds_work

comment:4 by theduckylittle, 12 years ago

Owner: set to theduckylittle
Status: needs_workassigned

comment:5 by theduckylittle, 12 years ago

Status: assignedtesting

comment:6 by theduckylittle, 12 years ago

Resolution: wontfix
Status: testingclosed

Actually, show-legend controls whether the legend is on by default "legend=" controls whether the legend control is to be displayed. I backed this change out after getting ahead of myself.

comment:7 by osjonathan, 12 years ago

Component: DemoDocs
Resolution: wontfix
Status: closedreopened

Ok. In that case you may wish to make this clearer in the documentation. Only "show-legend" appears there. There is an implied "legend=", but nothing explicit.

comment:8 by EliL, 12 years ago

Cc: EliL added

Can you please review this preliminary version of documentation,

http://geomoose.org/trunk/docs/mapbook.html?highlight=legend#catalog

I think that it already covers legend and show-legend, r859

comment:9 by osjonathan, 12 years ago

That page looks much better. Thanks!

comment:10 by EliL, 12 years ago

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.