Pass <param> to OpenLayers

[jimk]

Pass unused <param name"" value""/> children of map-sources into OpenLayers. This used to work in 2.4.

Currently implemented for the TMS layer in 2.6. This should be expanded in a uniform way across other map-source types.

[theduckylittle]

Actually this is

[theduckylittle]

Actually this is working ....

htdocs/geomoose/GeoMOOSE/MapSource/WMS.js:47

     _createOLLayer: function(options) {
                this._ol_layer_name = GeoMOOSE.id();
                this._ol_layer = new OpenLayers.Layer.WMS(
                        this._ol_layer_name,
                        this.urls,
                        this.params,
                        options
                );
        },

Some layers it is more appropriate to do this than others but, GeoMOOSE is passing those params along to WMS (and subsequently MapServer), and AGS layers. I'm not sure which others are appropriate but the consistency appears to be there.

[theduckylittle]

Also relevant is htdocs/geomoose/GeoMOOSE/MapSource.js:99

        _parseParams: function(mapbook_entry) {
                var paramsHash = {};
                var params = mapbook_entry.getElementsByTagName('param');

                for(var p = 0, len = params.length; p < len; p++) {
                        var param = params[p];
                        paramsHash[param.getAttribute('name')] = param.getAttribute('value');
                        //OpenLayers.Util.getXmlNodeValue(param);
                }
                return paramsHash;
        },

[jimk]

Dazed and confused, but trying to continue....

Ok, now I remember the discussion that initially prompted this ticket. It was when I implemented passing in <param> for TMS layers in r819, I noticed that this was a common task that was being handled differently across the layer types. My thought was this code would be easier to maintain if it was refactored up to MapSource.js and inherited by all (most) layer types instead of defined slightly differently for each different layer type.

[theduckylittle]

Enhancements from #66 made this ticket 'fall out'.