#6898 closed defect (fixed)
swig perl non void function return garbage
Reported by: | brunofriedmann | Owned by: | Ari Jolma |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | PerlBindings | Version: | 2.2.0 |
Severity: | normal | Keywords: | |
Cc: |
Description
Trying to update our openSUSE package to version 2.2.0 I receive a error check from our bot code checker about functions that are non void, but return undefine data.
swig/perl/gdal_wrap.cpp line 1828 AV* to_array_classifier(SV* classifier, int* comparison, const char error){}
This is also present in swig/include/perl/band.i line 89
I've created a patch (but please consider my knowledge of C and swig being very low). The software build correctly on our tools Patch attached for review.
Attachments (1)
Change History (5)
by , 7 years ago
Attachment: | fix-non-void-return.patch added |
---|
comment:1 by , 7 years ago
Thanks for this. The code is indeed a bit sloppy and for new (and should be marked as experimental) methods. I'll fix these.
comment:4 by , 7 years ago
Thanks Ari, I've picked your patches in my build now, waiting next bugfix release.
Proposed patch to fix non-void function return garbage