Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#6843 closed defect (fixed)

OGR DWG plugin broken for teigha in 2.1.*

Reported by: bartoli Owned by: warmerdam
Priority: normal Milestone: 2.1.4
Component: default Version: 2.1.3
Severity: normal Keywords:
Cc:

Description

I tried switching from gdal 1.11.* top 2.1.*, that i build myself, along with the dwg plugin using Teigha libraries.

2 days ago there was this commit in trunk : https://trac.osgeo.org/gdal/changeset/37820

I think a similar modification is needed in the 2.1 branches. In 2.1.3, I get unresolved symbols rbspline() and rbsplinu() in dwg/ogrdwglayer.cpp, which have been removed from ../dxf/intronumbs.cpp in this branch, so at least the modification that uses rbspline2 should be backported in 2.1.*

Change History (6)

comment:1 Changed 3 years ago by bartoli

Oh, and while you will be near dwg/ogrdwblocksglayer.cpp, this extra comma makes a VS2015 build fail :

***************
*** 38,44 ****
  
  OGRDWGBlocksLayer::OGRDWGBlocksLayer( OGRDWGDataSource *poDSIn ) :
      poDS(poDSIn),
!     poFeatureDefn(new OGRFeatureDefn( "blocks" )),
  {
      ResetReading();
 

comment:2 Changed 3 years ago by Even Rouault

In 37832:

DWG: restore rbspline() and rbsplinu() functions that were removed per r33888, #6436 because unused by the DXF driver (refs #6843)

comment:3 Changed 3 years ago by Even Rouault

Resolution: fixed
Status: newclosed

In 37833:

DWG: fix compilation problems (fixes #6843)

comment:4 Changed 3 years ago by Even Rouault

In 37834:

Remove tabulations (refs #6843)

comment:5 Changed 3 years ago by Even Rouault

In 37835:

Make old rbspline() used new rbspline2() (refs #6843)

comment:6 Changed 3 years ago by Even Rouault

In 37836:

Stupid me: we must ask for knot generation (refs #6843)

Note: See TracTickets for help on using tickets.