[PATCH] ISCE dataset properties are not case sensitive

[mazhe]

Hello,

Usage of multiple version of the ISCE software showed that it does not enforce case sensitivity in its XML header.

This could lead to basic image properties (x/y size, number of bands, etc) being copied to the metadata catalog that could then replace valid values when updating the header file.

Here are two patch, one for trunk and one for the 2.1 branch to switch usage of strcmp()'s to strcasecmp()'s to avoid this.

[mazhe]

use strcasecmp to filter properties in the isce driver (2.1 branch)

[mazhe]

use strcasecmp to filter properties in the isce driver (trunk)

[Even Rouault]

strcasecmp() doesn't exist in MSVC (at least not in older versions). Could you replace strcasecmp(a,b)==0 with EQUAL(a,b) ? The EQUAL macro defined in port/cpl_port.h will expand to whatever is available on the platform.

[mazhe]

Ho, this is even better! I was suspicious of strcasecmp, and was a bit fast reading cpl_port.h. I'll update the patchs in a few secs.

[mazhe]

Switch strcmp()s to EQUAL to avoid case issues (patch for trunk)

[mazhe]

Switch strcmp()s to EQUAL to avoid case issues (patch for 2.1.x)

[mazhe]

Here we go. It also filter the byte_order information to be included in metadata, as it could be saved with a wrong information too.

Thanks again

[Even Rouault]

In 35255:

ISCE: make parsing of properties case insensitive (patch by mazhe, fixes #6637)

[Even Rouault]

In 35256:

ISCE: make parsing of properties case insensitive (patch by mazhe, fixes #6637)