[PATCH] Fix BIP pixel offset in ROI_PAC driver

[mazhe]

Hello, I'm a bit ashamed that the ROI_PAC driver display the same BIP interleaving offset error as the ISCE driver.

Here's a patch inspired from the ISCE one to fix issue with valid and invalid files.

Sorry for the trouble, and thank you again for your work.

[mazhe]

Fix BIP offset computation, take into account bad files

[mazhe]

I forgot to mention that the versions affected are 2.0.0 -> 2.0.3, 2.1.0, and 2.1.1RC. Can the corresponding branches get this patch?

Thanks again

[Even Rouault]

In 34638:

ROI_PAC: fix computation of line offset for multi-band BIP files, and warn if detecting a wrong file produced by GDAL >= 2.0.0 (patch by mahze, fixes #6591)

[Even Rouault]

In 34639:

ROI_PAC: fix computation of line offset for multi-band BIP files, and warn if detecting a wrong file produced by GDAL >= 2.0.0 (patch by mahze, fixes #6591)

[Even Rouault]

In 34640:

ROI_PAC: fix computation of line offset for multi-band BIP files, and warn if detecting a wrong file produced by GDAL >= 2.0.0 (patch by mahze, fixes #6591)

[Even Rouault]

Applied in trunk, 2.1 branch (post 2.1.1RC2) and 2.0 branch (post 2.0.3RC2). I didn't apply the changes in the ISCE driver that were included in the patch.

[Even Rouault]

(meaning: the ISCE changes should go to another ticket)

[mazhe]

Sorry, I was not clear : the issue was actually fixed in ISCE, and the notification I got actually prompted me to investigate ROI_PAC as well.

Everything's good, thanks!

[Even Rouault]

You are clear but if you look at roipacdataset_fixbip.diff you'll see it contains unrelated ISCE changes. Probably a work in progress of yours

[mazhe]

Ho, you're right! Yes, you were right to ignore that part, it's really far from being complete. Thanks again.

[Even Rouault]

Fix will be included in potential future 2.0.4 / 2.1.2