Propose removing CPLReadDir() ABI compatibility function and possibly #define CPLReadDir

[Kurt Schwehr]

This should probably wait until after the 2.1.0 branch is created.

Can we retire the CPLReadDir ABI hack in cpl_vsil.cpp? What exactly was this needed anyway?

/************************************************************************/
/*                             CPLReadDir()                             */
/*                                                                      */
/*      This is present only to provide ABI compatibility with older    */
/*      versions.                                                       */
/************************************************************************/
#undef CPLReadDir

CPL_C_START
char CPL_DLL **CPLReadDir( const char *pszPath );
CPL_C_END

char **CPLReadDir( const char *pszPath )
{
    return VSIReadDir( pszPath );
}

I am planning to convert all CPLReadDir() calls to VSIReadDir() so that internally to GDAL, the #define CPLReadDir VSIReadDir in port/cpl_vsi.h is no longer used.

Is there code external to GDAL that still needs this #define? Can we remove it?

[Even Rouault]

It is at least used by MapServer in ​https://github.com/mapserver/mapserver/blob/branch-7-0/mapogroutput.c

[Kurt Schwehr]

Is the #define enough?

[Even Rouault]

Replying to goatbar:

Is the #define enough?

Not sure to understand your question. Enough to make MapServer compile happily yes :-)

[Even Rouault]

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub. If you believe this ticket is still valid, you may file it to ​https://github.com/OSGeo/gdal/issues if it is not already reported there.