Opened 6 years ago

Closed 3 years ago

#6444 closed task (wontfix)

Propose removing CPLReadDir() ABI compatibility function and possibly #define CPLReadDir

Reported by: Kurt Schwehr Owned by: Kurt Schwehr
Priority: normal Milestone: closed_because_of_github_migration
Component: default Version: svn-trunk
Severity: normal Keywords:
Cc:

Description

This should probably wait until after the 2.1.0 branch is created.

Can we retire the CPLReadDir ABI hack in cpl_vsil.cpp? What exactly was this needed anyway?

/************************************************************************/
/*                             CPLReadDir()                             */
/*                                                                      */
/*      This is present only to provide ABI compatibility with older    */
/*      versions.                                                       */
/************************************************************************/
#undef CPLReadDir

CPL_C_START
char CPL_DLL **CPLReadDir( const char *pszPath );
CPL_C_END

char **CPLReadDir( const char *pszPath )
{
    return VSIReadDir( pszPath );
}

I am planning to convert all CPLReadDir() calls to VSIReadDir() so that internally to GDAL, the #define CPLReadDir VSIReadDir in port/cpl_vsi.h is no longer used.

Is there code external to GDAL that still needs this #define? Can we remove it?

Change History (4)

comment:2 Changed 6 years ago by Kurt Schwehr

Is the #define enough?

comment:3 in reply to:  2 Changed 6 years ago by Even Rouault

Replying to goatbar:

Is the #define enough?

Not sure to understand your question. Enough to make MapServer? compile happily yes :-)

comment:4 Changed 3 years ago by Even Rouault

Milestone: closed_because_of_github_migration
Resolution: wontfix
Status: newclosed

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub?. If you believe this ticket is still valid, you may file it to https://github.com/OSGeo/gdal/issues if it is not already reported there.

Note: See TracTickets for help on using tickets.