Mistake in the configuration HAVE_SETLOCALE

[alaindelplanque]

gdal configure doesn't set properly HAVE_SETLOCALE.

In configure.in :

AC_CHECK_FUNC(setlocale)

should be replace by :

AC_CHECK_FUNCS(setlocale)

And in gdal/port/cpl_config.h.in, missing :

/* Define to 1 if you have the `setlocale' function. */
#undef HAVE_SETLOCALE

This causes a bug in internal libjson. Without HAVE_SETLOCALE, locale isn't set properly, and geojson coordinates are truncated to int values.

This bug was first reported in qgis: ​https://hub.qgis.org/issues/14578

[Even Rouault]

This issue only affects GDAL < 2 (with internal libjson). In GDAL 2, the internal libjson has been patched so that json_parse_double() uses GDAL CPLStrtod() that ignores the locale, and we want to avoid playing with setlocale() because it is not thread-safe.

However this ticket called 2 commits :

• trunk r33877 "configure: remove useless AC_CHECK_FUNC(setlocale) (#6438)"
• trunk r33878 "GeoJSON: use CPLThreadLocaleC with external libjson (#6438)"

[Even Rouault]

trunk r33880 "Revert r33878: external libjson already does setlocale() stuff (#6438)"

[alaindelplanque]

Thank. I have just built gdal dev (internal libjson) + qgis, it work fine.