Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#6407 closed defect (fixed)

[PATCH] Fix .amp images dimensions in ROI_PAC driver

Reported by: mazhe Owned by: warmerdam
Priority: normal Milestone:
Component: default Version: unspecified
Severity: normal Keywords: driver, roi_pac
Cc:

Description

Hello,

I recently discovered that for one of the image subtypes in the ROI_PAC driver (the .amp files), the FILE_LENGTH attribute do not represent the Y size of one band, but twice that value (band 1 ySize + band 2 ySize?).

So, while not very elegant, this case has to be managed when reading and writing ROI_PAC rasters.

I've written a patch to do so, would you consider review and include it? It's based against trunk, but I can do a backport to the 2.0 branch if that would allow to get it into a bugfix release.

Thank you for your time,

Attachments (1)

fix_roi_pac_amp.diff (3.7 KB ) - added by mazhe 8 years ago.
Adapt ysize setting to the image type (amp or not)

Download all attachments as: .zip

Change History (4)

by mazhe, 8 years ago

Attachment: fix_roi_pac_amp.diff added

Adapt ysize setting to the image type (amp or not)

comment:1 by Even Rouault, 8 years ago

Milestone: 2.0.3
Resolution: fixed
Status: newclosed

I've backported it to 2.0 branch but I'd appreciate if you could check I've done it correctly since "patch" did bad guess initially.

trunk r33682, branches/2.0 r33683 "ROI_PAC: fix .amp images dimensions (patch by mazhe, #6407)"

comment:2 by mazhe, 8 years ago

Ok, after a lot of testing, I am deeply sorry, but this issue was actually due to data corruption on our side (and a bit of ambigous format description in the Jet Propulsion Laboratory documentations).

Can the commit be reversed?

Once again, I'm very sorry,

Regards.

comment:3 by Even Rouault, 8 years ago

Milestone: 2.0.3

trunk r33718 "ROI_PAC: revert r33682 regarding .amp handling (#6407)"

branches/2.0 r33719 "ROI_PAC: revert r33683 regarding .amp handling (#6407)"

Note: See TracTickets for help on using tickets.