Opened 9 years ago

Closed 8 years ago

#5950 closed enhancement (fixed)

[PATCH] netCDF: optimize IReadBlock() and CheckData() handling of partial blocks in the x axis

Reported by: demaria Owned by: warmerdam
Priority: normal Milestone: 2.1.0
Component: GDAL_Raster Version: svn-trunk
Severity: normal Keywords: netcdf
Cc: Even Rouault

Description

netCDF: optimize IReadBlock() and CheckData() handling of partial blocks in the x axis by re-using the GDAL block buffer instead of allocating and free a new temporary buffer for each block

Attachments (1)

ticket5950.patch​ (7.1 KB ) - added by demaria 9 years ago.
Patch, autotest regression on netcdf.py and netcdf_cf.py is OK. No new unit test needed.

Download all attachments as: .zip

Change History (5)

by demaria, 9 years ago

Attachment: ticket5950.patch​ added

Patch, autotest regression on netcdf.py and netcdf_cf.py is OK. No new unit test needed.

comment:1 by Even Rouault, 9 years ago

It appears from ​http://rawgit.com/rouault/gdalautotest-coverage-results/master/coverage_html/frmts/netcdf/netcdfdataset.cpp.gcov.html there's no test coverage for the code you are optimizing.

comment:2 by Even Rouault, 9 years ago

Milestone: 2.0

Removing obsolete milestone

comment:3 by demaria, 8 years ago

Updated patch in this GIT PR: ​https://github.com/OSGeo/gdal/pull/97

comment:4 by Even Rouault, 8 years ago

Milestone: → 2.1.0
Resolution: → fixed
Status: new → closed

trunk r33493 "netCDF: optimize IReadBlock() and CheckData() handling of partial blocks in the x axis by re-using the GDAL block buffer instead of allocating a new temporary buffer for each block (#5950, patch by Julien Demaria)"

Note: See TracTickets for help on using tickets.