OGR can't create PCIDSK polygon file

[liminlu0314]

OGR cannot create the PCIDSK polygon vector data, Found in the GDAL library code is not achieved, I realize part of the code, surface vector data can create PCIDSK type.

The modified code is as follows: ogrpcidsklayer.cpp file OGRErr OGRPCIDSKLayer::SetFeature( OGRFeature *poFeature ):

		else if( wkbFlatten(poGeometry->getGeometryType()) == wkbPolygon )
		{
			OGRPolygon *poPoly = (OGRPolygon *) poGeometry;
			OGRLinearRing *poRing = NULL;
			poRing = poPoly->getExteriorRing();
			
			aoVertices.resize(poRing->getNumPoints());
			for(int i = 0; i < aoVertices.size(); i++ )
			{
				aoVertices[i].x = poRing->getX(i);
				aoVertices[i].y = poRing->getY(i);
				aoVertices[i].z = poRing->getZ(i);
			}

			int nRingSize = poPoly->getNumInteriorRings();
			if(nRingSize > 0 )
			{
				std::vector<PCIDSK::int32> anRingStart;
				anRingStart.resize(nRingSize+1);
				anRingStart[0] = poRing->getNumPoints();

				for (int iRing=0; iRing < nRingSize; iRing++)
				{
					int nCurrentStart = aoVertices.size();
					poRing = poPoly->getInteriorRing(iRing);
					anRingStart[iRing+1] = nCurrentStart + poRing->getNumPoints();
					aoVertices.resize(nCurrentStart + poRing->getNumPoints());

					for(int i = nCurrentStart; i < aoVertices.size(); i++ )
					{
						aoVertices[i].x = poRing->getX(i-nCurrentStart);
						aoVertices[i].y = poRing->getY(i-nCurrentStart);
						aoVertices[i].z = poRing->getZ(i-nCurrentStart);
					}
				}
				
				if(iRingStartField == -1)
				{
					iRingStartField = poVecSeg->GetFieldCount();
					OGRFieldDefn oField( "RingStart", OFTIntegerList );
					CreateField( &oField );
				}

				std::vector<PCIDSK::ShapeField> aoShapeFields;
				poVecSeg->GetFields(id, aoShapeFields);
				aoShapeFields[iRingStartField].SetValue(anRingStart);
				poVecSeg->SetFields( id, aoShapeFields );
			}
		}

[Even Rouault]

The creation of the RingStart field is inappropriate in SetFeature() as it modifies the schema of existing features and could result in crashes. That field should be available as soon GetLayerDefn() is called.

[Even Rouault]

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub. If you believe this ticket is still valid, you may file it to ​https://github.com/OSGeo/gdal/issues if it is not already reported there.