Opened 10 years ago
Closed 9 years ago
#5763 closed enhancement (fixed)
[PATCH] VICAR file format addition
Reported by: | swalter75 | Owned by: | warmerdam |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | default | Version: | unspecified |
Severity: | normal | Keywords: | vicar hrsc |
Cc: |
Description (last modified by )
VICAR is a file format similar to the PDS format. It is used by the VICAR software for many space missions.
http://www-mipl.jpl.nasa.gov/external/vicar.html
Vicar is not openly available, although there were efforts to make it Open Source by JPL in the last years.
The driver is tested for HRSC images, sample image here: http://hrscview.fu-berlin.de/mex4/5273/h5273_0000.nd4.50.bz2
It should work also for other missions, but probably meta-data handling has to be adapted. If you want a mission-specific file to be added, feel free to contact me, mailto:sebastian.walter@…
I wasn't able to commit via svn, so this is the diff to existing files:
Index: frmts/gdalallregister.cpp =================================================================== --- frmts/gdalallregister.cpp (revision 28072) +++ frmts/gdalallregister.cpp (working copy) @@ -231,6 +231,7 @@ GDALRegister_ISIS3(); GDALRegister_ISIS2(); GDALRegister_PDS(); + GDALRegister_VICAR(); #endif #ifdef FRMT_til Index: frmts/pds/GNUmakefile =================================================================== --- frmts/pds/GNUmakefile (revision 28072) +++ frmts/pds/GNUmakefile (working copy) @@ -1,13 +1,13 @@ include ../../GDALmake.opt -OBJ = pdsdataset.o isis2dataset.o isis3dataset.o nasakeywordhandler.o +OBJ = pdsdataset.o isis2dataset.o isis3dataset.o vicardataset.o nasakeywordhandler.o vicarkeywordhandler.o -CPPFLAGS := -I../raw $(CPPFLAGS) +CPPFLAGS := -I../raw $(GDAL_INCLUDE) $(CPPFLAGS) default: $(OBJ:.o=.$(OBJ_EXT)) -$(O_OBJ): nasakeywordhandler.h ../raw/rawdataset.h +$(O_OBJ): nasakeywordhandler.h vicarkeywordhandler.h ../raw/rawdataset.h clean: rm -f *.o $(O_OBJ) Index: gcore/gdal_frmts.h =================================================================== --- gcore/gdal_frmts.h (revision 28072) +++ gcore/gdal_frmts.h (working copy) @@ -120,6 +120,7 @@ void CPL_DLL GDALRegister_ISIS3(void); void CPL_DLL GDALRegister_ISIS2(void); void CPL_DLL GDALRegister_PDS(void); +void CPL_DLL GDALRegister_VICAR(void); void CPL_DLL GDALRegister_IDRISI(void); void CPL_DLL GDALRegister_Terragen(void); void CPL_DLL GDALRegister_WCS(void);
Attachments (3)
Change History (11)
comment:1 by , 10 years ago
Description: | modified (diff) |
---|
by , 10 years ago
Attachment: | vicarkeywordhandler.h added |
---|
by , 10 years ago
Attachment: | vicardataset.cpp added |
---|
by , 10 years ago
Attachment: | vicarkeywordhandler.cpp added |
---|
comment:2 by , 9 years ago
Milestone: | → 2.0 |
---|---|
Summary: | VICAR file format addition → [PATCH] VICAR file format addition |
comment:3 by , 9 years ago
comment:6 by , 9 years ago
Sebastian,
I get random failures on the Travis continuous integration system on the simple test I've added. Those failures arise systematically apparently on Mac, but randomly on Ubuntu 12.04. I've never managed to reproduce them on my machine.
The error is the inversion of the sign of geotransform[3] (upper left northing)
For example https://api.travis-ci.org/jobs/56025518/log.txt?deansi=true
Running tests from gdrivers/vicar.py
TEST: vicar_1 ...
old = (-53960.0, 25.0, 0.0, -200830.0, 0.0, -25.0) new = (-53960.0, 25.0, 0.0, 200830.0, 0.0, -25.0) fail
It would be good if you could investigate what's happening. Nothing shows up under Valgrind...
r28792 "vicar.py: avoid test failure on Travis until we've found what's wrong... (#5763)"
comment:8 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
trunk r28786 "Add GDAL VICAR format, patch by Sebastian Walter + a few extra fixes (#5763)"
My changes consist in mentionning VICAR in format_list.html, removing some tab characters, making the Identify() test harder, fixing a Valgrind warning in VICARKeywordHandler::Ingest()