Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5618 closed defect (fixed)

return statements in OGRLayerDecorator::SetStyleTable[Directly]

Reported by: akhliustov Owned by: warmerdam
Priority: normal Milestone: 1.11.1
Component: ConfigBuild Version: unspecified
Severity: normal Keywords:
Cc:

Description

http://trac.osgeo.org/gdal/browser/trunk/gdal/ogr/ogrsf_frmts/generic/ogrlayerdecorator.cpp#L189
http://trac.osgeo.org/gdal/browser/trunk/gdal/ogr/ogrsf_frmts/generic/ogrlayerdecorator.cpp#L194
These are valid C++, but they worsen the readability, being inconsistent with other void-functions of OGRLayerDecorator.
(And one of my compilers — quite an exotic one — actually rejects them.)

Change History (2)

comment:1 Changed 6 years ago by Even Rouault

Component: OGR_SFConfigBuild
Milestone: 1.11.1
Resolution: fixed
Status: newclosed

Didn't even know this was valid C++... What is your compiler actually ?

Fixed in trunk (r27587) and branches/1.11 (r27588)

comment:2 Changed 6 years ago by akhliustov

Thanks.

The compiler is Watcom C/C++ for QNX. It isn't supposed to be supported, of course.

Note: See TracTickets for help on using tickets.