Opened 10 years ago
Closed 10 years ago
#5416 closed enhancement (fixed)
WAsP .map driver for ogr
Reported by: | vmo | Owned by: | warmerdam |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | OGR_SF | Version: | unspecified |
Severity: | normal | Keywords: | |
Cc: |
Description
The attached patch implements an ogr driver to read or write .map files used by WAsP (http://en.wikipedia.org/wiki/WAsP).
The .map files contains height contours and/or roughness zones, the former are linestrings with an height attribute, the later are linestrings that separate two adjacent polygons with a roughness parameter on the righ and left sides.
A python test script is included (to be added to autotest/ogr) .
Attachments (5)
Change History (9)
by , 10 years ago
comment:1 by , 10 years ago
Patch committed in trunk in r27030 with a few additions/changes : 2 makefile.vc files for Windows support, link to the driver doc in ogr_formats.html, change of version in drv_wasp.html from GDAL 1.9 to 1.11.
trunk r27031 "Fix a few warnings raised by MSVC"
Would you mind relicencing ogr_wasp.py under X/MIT instead of LGPL ? (I guess you took inspiration from a few existing autotest script that are LGPL more or less by error)
comment:2 by , 10 years ago
The driver seems to crash when GEOS is not available (which breaks at least 2 of our Travis configurations : https://travis-ci.org/rouault/gdal_coverage/builds )
Cf https://s3.amazonaws.com/archive.travis-ci.org/jobs/20719892/log.txt :
Running tests from ogr/ogr_wasp.py TEST: ogr_wasp_create_ds ... success TEST: ogr_wasp_elevation_from_linestring_z ... success TEST: ogr_wasp_elevation_from_linestring_z_toler ... ERROR 6: GEOS support not enabled. /Users/travis/build.sh: line 339: 43069 Segmentation fault: 11 python run_all.py
and
https://s3.amazonaws.com/archive.travis-ci.org/jobs/20719897/log.txt
fixme:msvcrt:MSVCRT__sopen_s : pmode 0x81b6 ignored Running tests from ogr/ogr_wasp.py TEST: ogr_wasp_create_ds ... success TEST: ogr_wasp_elevation_from_linestring_z ... success TEST: ogr_wasp_elevation_from_linestring_z_toler ... ERROR 6: GEOS support not enabled. wine: Unhandled page fault on read access to 0x0000000c at address 0xf6d61e (thread 0009), starting debugger... Application tried to create a window, but no driver could be loaded. Make sure that your X server is running and that $DISPLAY is set correctly. Unhandled exception: page fault on read access to 0x0000000c in 32-bit code (0x00f6d61e). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:00f6d61e ESP:0042f354 EBP:0042f354 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000000 EBX:00ebcd6e ECX:044f59f4 EDX:00000000 ESI:044f14e8 EDI:6164c7c0 Stack dump: 0x0042f354: 0042f398 00e525bc 00000000 00110000 0x0042f364: 005da4d8 00000000 00000000 00000000 0x0042f374: 00000000 044d6700 00000006 00000000 0x0042f384: 00000000 00000010 044e6020 044f14e8 0x0042f394: 044e6020 0042f3d8 00e52752 044f14e8 0x0042f3a4: 044d6700 0042f478 00000000 80000002 Backtrace: =>0 0x00f6d61e OGRLineString::getNumPoints+0x6(this=(nil)) [/home/travis/build/rouault/gdal_coverage/gdal/ogr/ogr_geometry.h:299] in libgdal-1 (0x0042f354) 1 0x00f6d61e OGRLineString::getNumPoints+0x5(this=0x44f14e8) [/home/travis/build/rouault/gdal_coverage/gdal/ogr/ogr_geometry.h:299] in libgdal-1 (0x0042f398) 2 0x00f6d61e OGRLineString::getNumPoints+0x5(this=0x44f14e8) [/home/travis/build/rouault/gdal_coverage/gdal/ogr/ogr_geometry.h:299] in libgdal-1 (0x0042f3d8) 3 0x00f6d61e OGRLineString::getNumPoints+0x5(this=0x44f14e8) [/home/travis/build/rouault/gdal_coverage/gdal/ogr/ogr_geometry.h:299] in libgdal-1 (0x0042f4a8) 4 0x00f6d61e OGRLineString::getNumPoints+0x5(this=0x44f14e8) [/home/travis/build/rouault/gdal_coverage/gdal/ogr/ogr_geometry.h:299] in libgdal-1 (0x0042f4d8) 5 0x00f6d61e OGRLineString::getNumPoints+0x5(this=(nil)) [/home/travis/build/rouault/gdal_coverage/gdal/ogr/ogr_geometry.h:299] in libgdal-1 (0x0042f508)
by , 10 years ago
changes licence of ogr_wasp.py to X/MIT (patch for autotest rev 27032)
comment:3 by , 10 years ago
Fixed segfault when geos is not supported.
Modified test to also pass in this case.
comment:4 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Segfault with no geos support fixed in r27062
patch from Revision: 27029