GDALRasterBlock::IsCached seems to ignore which band it belongs to

[daniel112@…]

I was just browsing through some of the caching code and thought that
GDALRasterBlock::IsCached looked a little bit odd, since it doesn't look at what
band it belongs to or did I missunderstand something?

[warmerdam]

Andrey,

I'm not sure where GDALRasterBlock::IsCached() is used, but I think Daniel 
is right.  It tests based on the block offsets but it doesn't check whether
the cached block is for the correct dataset.  Is this really what you want? 
Where is this method used? 

[dron]

Well... It is my fault and I don't know how it happens. The function
GDALRasterBlock::IsCached() does nothing useful and I don't know why it was
implemented in such way (probably it was too late night or something like). I
have removed that function and replaced it with the
GDALRasterBand::IsBlockCached(). It is used in the RawRasterBand::IRasterIO()
logic to decide whether we should use the direct or cached I/O. That was the
purpose of the IsCached() function in the first place.

Sorry about that.