Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#5289 closed defect (fixed)

ignore null in GetHistogram, update to ticket 4750 for GDT_Byte case

Reported by: nflood Owned by: warmerdam
Priority: normal Milestone: 1.11.0
Component: GDAL_Raster Version: unspecified
Severity: normal Keywords:
Cc:

Description

Ticket http://trac.osgeo.org/gdal/ticket/4750 by gillins was a welcome fix in consistency between ComputeStatistics and GetHistogram. However, it missed a special case in GetHistogram, for GDT_Byte datatype, when exactly 256 bins are used. This is, of course, a very common case, hence there is a special section of code for it, but the earlier patch missed this (quite understandably) and only fixed the more general case. Attached is a patch which brings the special case into line with the rest. This modification has been tested in gdal-1.10.1, and appears to behave, but the attached patch is against the current trunk (r26588). I have checked this modification with gillins, and he agrees.

Attachments (1)

gdalrasterband.cpp.hist_ignore_null_GByte_case.patch​ (615 bytes ) - added by nflood 10 years ago.

Download all attachments as: .zip

Change History (3)

by nflood, 10 years ago

Attachment: gdalrasterband.cpp.hist_ignore_null_GByte_case.patch​ added

comment:1 by Even Rouault, 10 years ago

Milestone: → 2.0
Resolution: → fixed
Status: new → closed

trunk r26590 "GDALRasterBand::GetHistogram(): ignore nodata values in the GDT_Byte special case (#5289, patch by nflood, complementary of #4750)"

comment:2 by Even Rouault, 10 years ago

Milestone: 2.0 → 1.11.0
Note: See TracTickets for help on using tickets.