dgnwrite.cpp:2 * bad call to memcpy ?

[dcb]

I just ran the static analysis tool "cppcheck" over the source code of gdal-1.10.1

It said many things, including

[dgnwrite.cpp:1076]: (error) Buffer is accessed out of bounds: psArc.quat [dgnwrite.cpp:1297]: (error) Buffer is accessed out of bounds: psCone.quat

Source code for the first one is

memcpy( psArc->quat, panQuaternion, sizeof(long)*4 );

I think you'd be better off with something like

memcpy( psArc->quat, panQuaternion, sizeof(panQuaternion[0]) * 4 );

[Even Rouault]

r26505 "DGN: use int instead of long (#5252). Code paths not actually triggered by the OGR DGN driver"

[Kyle Shannon]

Also fixes Coverity 1074430, 1074453, 1075076, 1075088