Opened 11 years ago
Closed 11 years ago
#5049 closed enhancement (fixed)
[PATCH] new warp algorithms - mode and average
Reported by: | etourigny | Owned by: | etourigny |
---|---|---|---|
Priority: | normal | Milestone: | 1.10.0 |
Component: | Algorithms | Version: | unspecified |
Severity: | normal | Keywords: | warp |
Cc: | antonio, warmerdam, Even Rouault |
Description (last modified by )
I have implemented mode and average warping algorithms, based on those used in overview creation. This code has been tested on a few datasets (see attachments) with all datatypes (Byte, Int, Float) but not all cases have been looked into (e.g. color tables, various projections). Any feedback and testing would be appreciated.
Attachments (4)
Change History (17)
by , 11 years ago
Attachment: | warp_average_mode.txt added |
---|
comment:1 by , 11 years ago
Description: | modified (diff) |
---|---|
Summary: | [PATCH] new warp methods - mode and average → [PATCH] new warp algorithms - mode and average |
comment:2 by , 11 years ago
Description: | modified (diff) |
---|
comment:3 by , 11 years ago
There are still some comments in there, because some transparency/nodata issues have not been fully tested.
comment:4 by , 11 years ago
Cc: | added |
---|
comment:5 by , 11 years ago
Cc: | added |
---|
Adding Frank and Even in CC, perhaps one of you could give some feedback? (esp. Frank which is the original author).
I am hesitant on a few issues - please look into the TODO comments if you have the time and inclination.
comment:6 by , 11 years ago
Regarding the TODOs:
- The outer loop check of the unified mask is not appropriate for these algorithms since there are multiple input points per output point, so just remove the commented out code.
- The chunk nodata mask is not meaningful in the warp context and that commented out code can be removed.
The code looks good. I'd encourage you to go ahead and commit it.
comment:7 by , 11 years ago
ok Frank thanks! am I right to assume this would make it into 1.10 ? If so, I will update docs also.
comment:10 by , 11 years ago
The pabSuccess array isn't used currently to determine if a target pixel can be computed. Furthermore there should likely be a pabSuccess and pabSuccess2.
comment:12 by , 11 years ago
added optimization for int16 - uses the same code as for byte data (r25895 and 25896)
comment:13 by , 11 years ago
Milestone: | → 1.10.0 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
patch