Opened 12 years ago

Closed 8 years ago

#4731 closed defect (fixed)

TABMAPFile still forces QUICK spatial index mode

Reported by: ossipoff Owned by: warmerdam
Priority: normal Milestone:
Component: OGR_SF Version: svn-trunk
Severity: normal Keywords: mitab
Cc: Daniel Morissette

Description

Even though #1678 (MITAB bug 1732) has been fixed, TABMAPFile still forces QUICK spatial, by setting m_bQuickSpatialIndexMode to TRUE. Is there any reason for this? I tried setting bQuickSpatialIndexMode to FALSE, and the optimized spatial index seems to work fine.

Change History (4)

comment:1 by Even Rouault, 12 years ago

Cc: Daniel Morissette added
Component: defaultOGR_SF
Keywords: mitab added

(The link to the GDAL bug is about something else, but the link to MITAB 1732 is indeed the right one )

Looking at MITAB history file, I see a comment indicating that the bug related to the optimized spatial indexing has been solved, but that it is still disabled by default, and indeed in the current state of mitab_tabfile.cpp, I see :

/* See bug 1732: Optimized spatial index produces broken files because
 * of the way CoordBlocks are split. For now we have to force using the
 * Quick (old) spatial index mode by default until bug 1732 is fixed.
 */
    m_bQuickSpatialIndexMode = TRUE;
//  m_bQuickSpatialIndexMode = FALSE;

So, indeed, this contradicts the doc of the MITAB driver that says that optimized spatial indexing is turned on by default.

The fix would be to change mitab_tabfile.cpp to have m_bQuickSpatialIndexMode = FALSE; defined again. But I let Daniel to assess the situation.

comment:2 by Jukka Rahkonen, 9 years ago

The issue seems to be corrected in trunk/gdal/ogr/ogrsf_frmts/mitab/mitab_tabfile.cpp but someone who understands it better should confirm before closing.

comment:3 by Even Rouault, 9 years ago

trunk r28097 "MITAB: update documentation about default being SPATIAL_INDEX_MODE=QUICK"

With GDAL 2.0, SPATIAL_INDEX_MODE can be set to OPTIMIZED (the doc and code behaviour didn't match previously. It was QUICK also, but there was no way of setting OPTIMIZED with OGR)

comment:4 by Even Rouault, 8 years ago

Resolution: fixed
Status: newclosed

Batch closing of MITAB tickets fixed in GDAL. They were kept open because not merged into MITAB separate repository, but the latter one is inactive, so let's close them definitely.

Note: See TracTickets for help on using tickets.