#4332 closed defect (fixed)
[PATCH] S57: fix S57Reader::ApplyRecordUpdate()
| Reported by: | Even Rouault | Owned by: | warmerdam |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.9.0 |
| Component: | OGR_SF | Version: | unspecified |
| Severity: | normal | Keywords: | s57 |
| Cc: | mrxonx@… |
Description
Saving contribution from http://lists.osgeo.org/pipermail/gdal-dev/2011-November/030752.html
Dear all, Included is a patch for s57reader.cpp that properly applies updates for certain types of charts. The essence of this patch is that SG2D field may not be present in original record, and must be added if update is trying to insert SG2D fields. The patch was made against our modified version of OGR, so line numbers likely do not match and certain function signatures may need to be updated. If you'd like to apply it - make sure it goes in the S57Reader::ApplyRecordUpdate. Best, -- Mike
Attachments (1)
Change History (3)
by , 12 years ago
| Attachment: | s57applyrecordupdate.patch added |
|---|
comment:1 by , 11 years ago
| Cc: | added |
|---|---|
| Milestone: | → 1.9.0 |
| Resolution: | → fixed |
| Status: | new → closed |
comment:2 by , 11 years ago
http://lists.osgeo.org/pipermail/gdal-dev/2011-December/031138.html mentions
Test chart is found in current UKHO data set, chart GB327200 (St. Helena). It's not a free data set, so I can't attach a copy, but UKHO should be willing to provide one free of charge, if requested, for test purposes.
Note:
See TracTickets
for help on using tickets.
The patch has been applied in trunk (r23517). I don't have test data demonstrating it is working as expecting so I am hesitant to backport it into 1.8 branch.