Adding SXF file format driver

[bidandou]

the goal of the work is to add a GDAL driver supporting the SXF (Storage and eXchange Format). This file format is largely used in the eastern europe, and is primarly produced by a GIS software Called Panorama GIS MAP developped by the Russian KB Panorama Entreprise
informationons on : ​http://www.gisinfo.net/
Specification on (in Russian Language) : ​http://gistoolkit.ru/download/doc/sxf4bin.pdf

[Even Rouault]

I have several high level remarks and questions :

• For significant contributions like a new driver, we'd ask that you publicly declare in an email to gdal-dev mailing list that your contribution matches the requirements of the "Legal" paragraph of http://trac.osgeo.org/gdal/wiki/rfc3_commiters
• Do you have rights to publish sxf.h under the X/MIT licence ? There's no copyright notice in the file, and I've got under the impression that it might come from another project. Please correct me if I'm wrong.
• Is there a public specification of the format somewhere ?
• You should put your full name in the copyright notice of the files, not the osgeo id.
• The first thing to fix is the indendation of the files. Please don't use tab characters, but use instead 4 spaces for each indentation level. See http://trac.osgeo.org/gdal/wiki/rfc8_devguide
• Remove dead code that is commented
• Remove printf statements. You can use CPLDebug infrastructure if needed
• Do you have links to SXF datasets that could be used to test your contribution ? Ideally we would need a freely redistribuable and small datasource so that a regression test can be written.
• With which OS did you test your driver : Linux, Windows ?
• Your code will only work on little-endian processors. Not a critical issue for now however...

Note : to avoid the proliferation of files when you update new revisions of your work, you can overwrite existing files attached to the ticket by checking the "Replace existing attachment of the same name" box.

CC'ing Andrey Kiselev who has contributed stuff in GDAL for Panorama SRS

Merci de votre contribution !

[bidandou]

SXF datasets that could be used to test the contribution : some SXF files exist on thos URL :
​http://gistoolkit.ru/download/

the most interesting thing is the availability of a free downladable softwares in the above site alowing the cration and the export of SXF files in different configurations to do tests.

see: ​http://www.gisinfo.net/download/download.htm

for the OS I used to test my driver : Windows XP SP3 and Windows 7?

I'm Using Visual Studio 2008 Expess Edition for the developpement. dont try to compile with gcc.

I submit the files above just to know how does mechanism of contriburions work. My work is not finished.

Thank you for your interest, soon I'll correct my work and I'll submit more comprehensible code.

[Even Rouault]

Ali, (sorry if I misidentified your first name ?)

Thanks for the updates.

• I'd note that there are still identations problems in ogrsxflayer.cpp.
• I suppose that the ogr_sxf_defs.h comes from the spec of ​http://gistoolkit.ru/download/doc/sxf4bin.pdf. Am I right ? Translated into English : ​http://translate.google.fr/translate?sl=ru&tl=en&u=http%3A%2F%2Fgistoolkit.ru%2Fdownload%2Fdoc%2Fsxf4bin.pdf
• I looked at the links you provided but couldn't find a SXF file sample in them. There are just too many files to open them one by one. Could you point me at the precise URL for a sample file ? Thanks
• Do you consider your work ready enough, or are there still some changes you intend to do before I start integrating ? You can always submit additional patches later.

[bidandou]

Yes you are right, the ogr_sxf_defs.h comes from the spec of the SXF file format transtated to english.

you can find an SXF file in :

​http://gistoolkit.ru/download/examplemap.zip

For now I consider that my work is not ready enough, there still some importants thinks to do, so I'd like to have time to do that.

Thank you for you assistance