Opened 8 years ago

Closed 7 months ago

#4116 closed defect (wontfix)

[PATCH] Use Kakadu "apps library" instead of using .o files directly

Reported by: warmerdam Owned by: warmerdam
Priority: normal Milestone: closed_because_of_github_migration
Component: GDAL_Raster Version: unspecified
Severity: normal Keywords: jp2kak
Cc:

Description

Directly linking the apps .o files complicates builds with Kakadu and it turns out doing a build in managed/make will build application libraries.

Attachments (1)

jp2kakbuild.patch (2.7 KB) - added by warmerdam 8 years ago.
Preliminary patch

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by warmerdam

Attachment: jp2kakbuild.patch added

Preliminary patch

comment:1 Changed 8 years ago by warmerdam

note that the patch requires including roi_sources.cpp and rou_sources.h from apps/kdu_compress in the jp2kak directory. Unfortunately these are the properly of Dr. Taubman and UNSW, so to avoid intellectual property contamination I have shelved this build approach. This ticket and patch are to preserve the work done on this in case we pick it up again.

comment:2 Changed 5 years ago by Jukka Rahkonen

Summary: Use Kakadu "apps library" instead of using .o files directly[PATCH] Use Kakadu "apps library" instead of using .o files directly

comment:3 Changed 2 years ago by bugbuster

I do not know how it used to work when this ticket was opened. Nowadays, Kakadu is compiled as two libraries :

  • kdu_VxxR.dll
  • kdu_axxR.dll

Last year, I opened a ticket for improvement at Kakadu support. They kindly implemented some modifications so that everything GDAL needs is contained in DLLs.

At least with my current version (Kakadu V7.9.1), the two Kakadu libraries contain all the necessary symbols. Thus, it is now possible to have a cleaner Kakadu plugin compilation with just two modifications :

  • nmake.opt : modify KAKLIB to indicate both libraries
    KAKLIB = $(KAKDIR)\lib_x64\kdu_v79R.lib $(KAKDIR)\lib_x64\kdu_a79R.lib
    
  • get rid of OBJ file list in both makefiles in frmts/jp2kak and frmts/jpipkak

comment:4 Changed 2 years ago by Even Rouault

In 39503:

Windows build for Kakadu: add capability to build as a plugin, and make it possibly to link only against the Kakadu .lib/.dll instead of incorporating some of its .obj (patch by Phillipe Ghesquiere, fixes #6940, refs #4116)

comment:5 Changed 7 months ago by Even Rouault

Milestone: closed_because_of_github_migration
Resolution: wontfix
Status: newclosed

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub?. If you believe this ticket is still valid, you may file it to https://github.com/OSGeo/gdal/issues if it is not already reported there.

Note: See TracTickets for help on using tickets.