Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#3862 closed defect (fixed)

ASRP datatset loading problem

Reported by: morabit Owned by: warmerdam
Priority: normal Milestone:
Component: GDAL_Raster Version: 1.7.3
Severity: normal Keywords:
Cc:

Description

Hi,
first of all thank you very much for the support provided in ticket #3848.
Few weeks ago we had another problem with a different format:
an .IMG file included in a ASRP dataset that belongs to our testsuite.
After some investigation, we found that the problem was due to a failed assert
preceeding the actual creation of the TILEINDEX array.
We were able to fix that problem applying a little patch to gdal 1.7.3.
We replaced the following test in srpdataset.cpp, line 567:

if (field->GetDataSize() != nIndexValueWidth * NFL * NFC + 1)
{
	return FALSE;
}


with

if (field->GetDataSize() < nIndexValueWidth * NFL * NFC + 1)
{
	return FALSE;
}



This relaxed check appears to be safe because it includes the previously used strict check
and doesn't cause errors to the subsequent array creation code.
If you think this is safe and correct, can you include this patch in your next official release?
Or, in case you think it's not completely correct, can you apply your fix to this problem?

We 'd like to link against the official release instead to have to mantain our 1.7.3-patched version.
By the way, when it is scheduled next official release?
Next official release is milestone 1.8.0 or there will be other intermediate versions?


Thank you for the support
Bruno M.

Change History (2)

comment:1 Changed 9 years ago by Even Rouault

Priority: highnormal
Resolution: fixed
Severity: blockernormal
Status: newclosed

Hum, another weird dataset I guess. Your fix is safe. So applied in trunk (r21203) and in branches/1.7 (r21204)

comment:2 Changed 7 years ago by Even Rouault

Milestone: 1.7.4

Milestone 1.7.4 deleted

Note: See TracTickets for help on using tickets.