Opened 13 years ago

Closed 13 years ago

#3850 closed defect (fixed)

VSIL_STRICT_ENFORCE macro and debug applications

Reported by: rprinceley Owned by: warmerdam
Priority: normal Milestone: 1.8.0
Component: ConfigBuild Version: svn-trunk
Severity: normal Keywords:

Description (last modified by rprinceley)

Debug builds of Windows applications define _DEBUG (not DEBUG), the check in cpl_vsi.h should include _DEBUG so linking against debug version of GDAL uses correct VSILFILE definition.

/* Make VSIL_STRICT_ENFORCE active in DEBUG builds */
#ifdef DEBUG

Change History (3)

comment:1 by rprinceley, 13 years ago

Description: modified (diff)

comment:2 by warmerdam, 13 years ago

Component: defaultConfigBuild
Status: newassigned

A review of nmake.opt shows that debug builds on windows do not actually define DEBUG as they do on unix. I have modified nmake.opt (r21165) so that it does define DEBUG in debug builds. In addition to the VSILFILE stuff, the main other aspect driven by this macro is enabling assertions.

Note that none of the default build configurations for GDAL on windows use the debug runtimes and there is no particular reason that use of the debug runtimes needs to be linked with use of the DEBUG macro as far as I can see.

Leaving open pending a test build on windows ...

comment:3 by warmerdam, 13 years ago

Resolution: fixed
Status: assignedclosed

Adjustment confirmed.

Note: See TracTickets for help on using tickets.