Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#3716 closed enhancement (fixed)

[PATCH] Set Ignored Fields

Reported by: wonder Owned by: warmerdam
Priority: normal Milestone: 1.8.0
Component: OGR_SF Version: unspecified
Severity: normal Keywords:
Cc:

Description

The attached patches implement support in OGR for optional ignoring of fields, geometry and style as specified in RFC29:

http://trac.osgeo.org/gdal/wiki/rfc29_desired_fields

The "base" patch implements the generic infrastructure, the "shape" patch implements the support for shapefile driver.

Attachments (2)

set_ignored_fields_base.diff (16.2 KB) - added by wonder 10 years ago.
set_ignored_fields_shape.diff (1.4 KB) - added by wonder 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by wonder

Changed 10 years ago by wonder

comment:1 Changed 10 years ago by wonder

Please could you review the patches and post your comments so that it can be included into trunk soon?

Thanks

Martin

comment:2 Changed 10 years ago by warmerdam

Status: newassigned

I've marked the RFC as adopted based on the voting history information and I will review the diffs and apply.

comment:3 Changed 10 years ago by warmerdam

Patches apply and build cleanly - but I've changed bool to int. Hmm, no swig bindings or test suite ... this will take a while.

comment:4 Changed 10 years ago by warmerdam

Resolution: fixed
Status: assignedclosed

I have applied the patch with a few adjustments (bool), and addition of swig bindings in trunk (r20885). I've also introduced minimal testing of the shapefile implementation in the autotest suite (r20884).

comment:5 Changed 10 years ago by Even Rouault

r20886: ogr2ogr: when specifying -select option, use SetIgnoredFields?() on source layer when possible (#3716)

comment:6 Changed 10 years ago by Even Rouault

r20897 /trunk/gdal/ogr/ogrsf_frmts/generic/ (ogr_gensql.cpp ogr_gensql.h): Generic SQL: analyse the SELECT expression to determine which fields are unused so as to use SetIgnoredFields?()

Note: See TracTickets for help on using tickets.