revised TerraSAR driver

[shawngong]

TerraSAR GDAL driver can only utilizes 5 GCPs (4 coners plus centre). Adam Klein (my colleague) modified it so that it uses all GCPs in *.xml

I attached two output of gdalinfo, the 1st one is from the current GDAL driver; the 2nd one is from the revised drivr.

[pvachon]

I'll have a look through this code and make any comments. P.

[pvachon]

Hi Shawn,

I've applied the changes. Thanks for the code.

P.

[shawngong]

Thanks, Phil

[shawngong]

I submit an updated TerraSAR-X driver: tsxdataset.cpp1

Changes made by my coworker Adam Klein as follows:

• Open() will return NULL when one of the raster bands cannot be loaded. This fix prevents a crash (dereferencing NULL pointer).
• The driver no longer saves the image file pointer (it was never being used anyway) and does not clear the file pointer passed to Open() through GDALOpenInfo. This fix allows GDAL to close the image file when it is done with it.
• Replace strdup() with CPLStrdup() for consistency
• Calling CPLDestroyXMLNode() to clean up before returning NULL in Open()

[Jukka Rahkonen]

Is there anybody out there to check the patch tsxdataset.cpp1?

[Even Rouault]

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub. If you believe this ticket is still valid, you may file it to ​https://github.com/OSGeo/gdal/issues if it is not already reported there.