Opened 10 years ago

Closed 9 months ago

#3564 closed enhancement (wontfix)

revised TerraSAR driver

Reported by: shawngong Owned by: pvachon
Priority: normal Milestone: closed_because_of_github_migration
Component: default Version: unspecified
Severity: normal Keywords:
Cc: antonio

Description

TerraSAR GDAL driver can only utilizes 5 GCPs (4 coners plus centre). Adam Klein (my colleague) modified it so that it uses all GCPs in *.xml

I attached two output of gdalinfo, the 1st one is from the current GDAL driver; the 2nd one is from the revised drivr.

Attachments (4)

tsxdataset.cpp (26.6 KB) - added by shawngong 10 years ago.
t1.txt (1.6 KB) - added by shawngong 10 years ago.
t2.txt (184.4 KB) - added by shawngong 10 years ago.
tsxdataset.cpp1 (26.8 KB) - added by shawngong 10 years ago.

Download all attachments as: .zip

Change History (13)

Changed 10 years ago by shawngong

Attachment: tsxdataset.cpp added

Changed 10 years ago by shawngong

Attachment: t1.txt added

Changed 10 years ago by shawngong

Attachment: t2.txt added

comment:1 Changed 10 years ago by shawngong

Type: defectenhancement

comment:2 Changed 10 years ago by pvachon

Owner: changed from warmerdam to pvachon
Status: newassigned

comment:3 Changed 10 years ago by pvachon

I'll have a look through this code and make any comments. P.

comment:4 Changed 10 years ago by pvachon

Resolution: fixed
Status: assignedclosed

Hi Shawn,

I've applied the changes. Thanks for the code.

P.

comment:5 Changed 10 years ago by shawngong

Thanks, Phil

Changed 10 years ago by shawngong

Attachment: tsxdataset.cpp1 added

comment:6 Changed 10 years ago by shawngong

Resolution: fixed
Status: closedreopened

I submit an updated TerraSAR-X driver: tsxdataset.cpp1

Changes made by my coworker Adam Klein as follows:

  • Open() will return NULL when one of the raster bands cannot be loaded. This fix prevents a crash (dereferencing NULL pointer).
  • The driver no longer saves the image file pointer (it was never being used anyway) and does not clear the file pointer passed to Open() through GDALOpenInfo. This fix allows GDAL to close the image file when it is done with it.
  • Replace strdup() with CPLStrdup() for consistency
  • Calling CPLDestroyXMLNode() to clean up before returning NULL in Open()

comment:7 Changed 8 years ago by antonio

Cc: antonio added

comment:8 Changed 5 years ago by Jukka Rahkonen

Is there anybody out there to check the patch tsxdataset.cpp1?

comment:9 Changed 9 months ago by Even Rouault

Milestone: closed_because_of_github_migration
Resolution: wontfix
Status: reopenedclosed

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub?. If you believe this ticket is still valid, you may file it to https://github.com/OSGeo/gdal/issues if it is not already reported there.

Note: See TracTickets for help on using tickets.