source code levellerdataset.cpp error

[gradmeow]

​http://download.osgeo.org/gdal/gdal171.zip

In this release, there is a error at gdal-1.7.1\frmts\leveller\levellerdataset.cpp. In Line 171, "{ "?, kPI / 180.0, UNITLABEL_DEGREE }", lack of " after ? will result a build error.

[gradmeow]

line 171

[warmerdam]

I have reviewed the code at this line, and it appears there is a UTF-8 or otherwise special character in the string constant:

warmerda@gdal64[5]% od -c
        { "°", kPI / 180.0, UNITLABEL_DEGREE },
0000000  \t   {       " 302 260   "   ,       k   P   I       /       1
0000020   8   0   .   0   ,       U   N   I   T   L   A   B   E   L   _
0000040   D   E   G   R   E   E       }   ,  \n
0000052

The solution would appear to be to replace it with a proper escape sequence rather than embedding a special character. However, this does not appear to adversely affect most compilers. What compiler are you building with? Is there anything unusual about your language/encoding environment?

[rayg]

My bad. Have replaced the degree symbol with \xB0 (Unicode codepoint for the degree symbol).

[warmerdam]

I have backported the patch into 1.7 branch (r19149). Ray's fix was in trunk (r19148).

I'm still interested in hearing what compiler/language environment this affected.

Thanks for the very fast fix Ray.

[gradmeow]

Replying to warmerdam:

I have backported the patch into 1.7 branch (r19149). Ray's fix was in trunk (r19148).

I'm still interested in hearing what compiler/language environment this affected.

Thanks for the very fast fix Ray.

Thank you! My compiler is vc9.0 along with visual studio 2008.