Opened 11 years ago

Closed 6 years ago

#3410 closed enhancement (fixed)

Add missing multipoint support to MITAB

Reported by: gaige Owned by: warmerdam
Priority: normal Milestone:
Component: OGR_SF Version: svn-trunk
Severity: normal Keywords: mitab
Cc: Daniel Morissette

Description

Previously Map Info TAB format files could read but not write multipoint geometry. This adds writing multipoint geometry to the CreateFeature? code.

I apologize for the lack of test files for you. Fortunately, I have a really nice round-trip testbed that allows me to verify that the data written and the data read are the same (within a very specific set of parameters), unfortunately it's tied tightly to my software and can't be separated out for distribution.

==== /ogr/ogrsf_frmts/mitab/mitab_imapinfofile.cpp
357d356
<       case wkbMultiPoint:
372a372,381
>       case wkbMultiPoint:
>         poTABFeature = new TABMultiPoint(poFeature->GetDefnRef());
>         if(poFeature->GetStyleString())
>         {
>             poTABPointFeature = (TABPoint*)poTABFeature;
>             poTABPointFeature->SetSymbolFromStyleString(
>                 poFeature->GetStyleString());
>         }
> 		break;
> 		

Change History (4)

comment:1 Changed 11 years ago by Even Rouault

Cc: Daniel Morissette added
Keywords: mitab added

Gaige,

the normal process for changing files belonging to MITAB is to submit them to upstream MITAB. CC'ing Daniel Morissette, the MITAB maintener.

comment:2 Changed 11 years ago by gaige

Got it. Thank you, -Gaige

comment:3 Changed 6 years ago by Jukka Rahkonen

I believe that multipoints are still not written but they are converted to many points but I am not sure. Waiting some comment from mitab folks.

comment:4 Changed 6 years ago by Even Rouault

Milestone: 1.8.1
Resolution: fixed
Status: newclosed

Just tested it works OK.

Note: See TracTickets for help on using tickets.