Opened 10 years ago

Closed 9 months ago

#3404 closed enhancement (wontfix)

Add Winkel, Tilted Perspective, and Near Sided Perspectives to srs api

Reported by: gaige Owned by: gaige
Priority: normal Milestone: closed_because_of_github_migration
Component: OGR_SRS Version: svn-trunk
Severity: normal Keywords:
Cc: warmerdam

Description

Found a need for these SRS. Implemented with Proj4.

Attachments (1)

srs-diff (12.0 KB) - added by gaige 10 years ago.
srs-diff

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by gaige

Attachment: srs-diff added

srs-diff

comment:1 Changed 10 years ago by Even Rouault

ogr/ogr_srs_validate.cpp should probably be updated with the added projections. swig/include/osr.i also to get the new API accessible by SWIG binding languages.

I'm not sure if it is the case, but when looking at your patch, I see odd indentations. Be careful to use space characters and not tab characters.

comment:2 Changed 10 years ago by warmerdam

Milestone: 1.7.2

This implies an extension to the ABI and should not in my opinion be done outside of trunk.

How did you come up with the WKT names for these projection methods? I'm trying hard to document projection methods at http://www.remotesensing.org/geotiff/proj_list/ and to avoid unnecessary conflicts with ESRI PE, and CS-Map when adding new projection methods.

comment:3 Changed 10 years ago by gaige

It makes sense to keep it out of the release branch and back in trunk. Frankly, I was unclear on what the particulars were at the time that I submitted the patch, although clearly I'm becoming more fluent in the rules now.

As for where I got the WKT names, the Winkel names were taken from examples in the wild and from: http://www.spatialreference.org/ref/esri/53018/ and similar links for each of them.

I was attempting to keep to names that were already well known, but in the case of the perspective versions, I couldn't find anything in the wild for WKT, so I made those two up.

That I should have documented better in my original notes.

Do we have a policy for handling WKT for which there aren't examples in the wild?

Thanks, -Gaige

comment:4 Changed 10 years ago by warmerdam

Cc: warmerdam added
Milestone: 1.8.0
Owner: changed from warmerdam to gaige

Gaige,

Go ahead with the ones for which there are ESRI examples.

For the others, perhaps you could seek advice on naming on the metacrs mailing list?

I'd hate to establish a conflicting name for any of these if there is already something in use somewhere.

comment:5 Changed 10 years ago by bishop

In http://trac.osgeo.org/gdal/ticket/3333 I have added some useful projection. According to the naming condition - this names (Aitoff, Winkel_I, Winkel_II, Winkel_Tripel, Craster_Parabolic, Loximuthal, Quartic_Authalic) was taken from the proj4 header files and are compatible with the ESRI ArGIS prj files.

comment:6 in reply to:  5 Changed 10 years ago by gaige

Replying to bishop:

In http://trac.osgeo.org/gdal/ticket/3333 I have added some useful projection. According to the naming condition - this names (Aitoff, Winkel_I, Winkel_II, Winkel_Tripel, Craster_Parabolic, Loximuthal, Quartic_Authalic) was taken from the proj4 header files and are compatible with the ESRI ArGIS prj files.

Thanks for the verification and I'll look at the other ones while I'm in there.

comment:7 Changed 5 years ago by Jukka Rahkonen

This ticket is probably partly fixed. File /trunk/gdal/ogr/ogr_srs_api.h (GDAL 2.0-dev) contains these three:

#define SRS_PT_WINKEL_I "Winkel_I" #define SRS_PT_WINKEL_II "Winkel_II" #define SRS_PT_WINKEL_TRIPEL "Winkel_Tripel"

These are missing:

#define SRS_PT_TILTED_PERSPECTIVE "Tilted_Perspective" #define SRS_PT_NEAR_SIDED_PERSPECTIVE "Near_Sided_Perspective" #define SRS_PP_PERSPECTIVE_TILT_ANGLE "perspective_tilt_angle"

comment:8 Changed 4 years ago by Even Rouault

Milestone: 1.8.1

Removing obsolete milestone

comment:9 Changed 9 months ago by Even Rouault

Milestone: closed_because_of_github_migration
Resolution: wontfix
Status: newclosed

This ticket has been automatically closed because Trac is no longer used for GDAL bug tracking, since the project has migrated to GitHub?. If you believe this ticket is still valid, you may file it to https://github.com/OSGeo/gdal/issues if it is not already reported there.

Note: See TracTickets for help on using tickets.