Opened 10 years ago

Closed 10 years ago

#3402 closed enhancement (fixed)

Fix CPLError calls in odbc routines to use a static string as first argument

Reported by: gaige Owned by: gaige
Priority: normal Milestone: 1.7.2
Component: default Version: svn-trunk
Severity: minor Keywords: odbc
Cc: warmerdam

Description

Correct the use of an initial non-static string argument in printf-style calls to CPLDebug and CPLError:

port/cpl_odbc.cpp

110c110
<             CPLDebug( "ODBC", pszEnvIni );
---
>             CPLDebug( "ODBC", "%s", pszEnvIni );
678c678
<                 CPLError( CE_Failure, CPLE_AppDefined,
---
>                 CPLError( CE_Failure, CPLE_AppDefined, "%s", 
691c691
<                 CPLError( CE_Failure, CPLE_AppDefined,
---
>                 CPLError( CE_Failure, CPLE_AppDefined, "%s", 
723c723
<                 CPLError( CE_Failure, CPLE_AppDefined,
---
>                 CPLError( CE_Failure, CPLE_AppDefined, "%s", 
764c764
<                     CPLError( CE_Failure, CPLE_AppDefined,
---
>                     CPLError( CE_Failure, CPLE_AppDefined, "%s", 

Change History (3)

comment:1 Changed 10 years ago by warmerdam

Cc: warmerdam added
Keywords: odbc added
Owner: changed from warmerdam to chaitanya

Chaitanya,

Please review and apply.

comment:2 Changed 10 years ago by warmerdam

Owner: changed from chaitanya to gaige

Gaige might as well take care of this himself.

comment:3 Changed 10 years ago by chaitanya

Resolution: fixed
Status: newclosed

Reviewed and applied the patch in trunk (r19175) and 1.7 branch (r19176).

Note: See TracTickets for help on using tickets.