Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3323 closed defect (fixed)

GRASS driver crash for location without projection

Reported by: rblazek Owned by: warmerdam
Priority: normal Milestone:
Component: GDAL_Raster Version: unspecified
Severity: normal Keywords: grass
Cc:

Description

QGIS bug http://trac.osgeo.org/qgis/ticket/2303

It is just stupid bug in GRASS driver, G_free_key_value() called on NULL, patch attached.

May I submit to svn?

Attachments (1)

grass57dataset.cpp.patch-noproj (653 bytes) - added by rblazek 11 years ago.

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by rblazek

comment:1 Changed 11 years ago by warmerdam

Component: defaultGDAL_Raster
Keywords: grass added

Radim,

Please go ahead, and it may be appropriate to backport to 1.6.

comment:2 Changed 11 years ago by Mateusz Łoskot

Radim,

Wouldn't it be simpler to fix G_free_key_value function in GRASS to follow semantic of free() and do nothing for null pointer? The G_free in GRASS already does nothing for null pointer.

comment:3 Changed 11 years ago by rblazek

Resolution: fixed
Status: newclosed

It would be definitely good to fix also in GRASS lib but simpler no because you have to wait ages until it gets into distros.

Fixed in changeset:18537.

comment:4 Changed 11 years ago by Mateusz Łoskot

Radim,

Understood, though I still suggest to apply the fix to GRASS as well. So, once new fixed version is released, messing 3rd parties code is no longer needed.

comment:5 Changed 11 years ago by Mateusz Łoskot

The issue has been fixed in GRASS (https://trac.osgeo.org/grass/ticket/866)

Note: See TracTickets for help on using tickets.