Opened 10 years ago

Closed 10 years ago

#3317 closed enhancement (fixed)

Patch enabling copy operations for VFKProperty class

Reported by: Mateusz Łoskot Owned by: martinl
Priority: normal Milestone:
Component: OGR_SF Version: svn-trunk
Severity: normal Keywords: vfk
Cc:

Description

This patch implements copy constructor and assignment operator for VFKProperty class. This addition makes it possible to replace manually allocated and managed list of properties

VFKProperty **m_papszProperty;

with std::vector in VFKFeature class. It simplifies implementation removing code and gets rid of allocation of each property on heap. The patch does not apply any other changes to public interace of the two classes.

The patch also includes some trivial improvements to naming style.

Note, there is number of other places where similar improvements are possible.

Attachments (1)

ogr-vfk-vfkproperty-copyable.patch (4.2 KB) - added by Mateusz Łoskot 10 years ago.
Patch making VFKProperty copyable and replaces manual list with std::vector

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by Mateusz Łoskot

Patch making VFKProperty copyable and replaces manual list with std::vector

comment:1 Changed 10 years ago by Even Rouault

Cc: martinl added

CC'ing Martin Landa as he's the maintener of the driver

comment:2 in reply to:  description Changed 10 years ago by martinl

Replying to mloskot:

This patch implements copy constructor and assignment operator for VFKProperty class. This addition makes it possible to replace manually allocated and managed list of properties

patch applied in r18509, thanks.

Note, there is number of other places where similar improvements are possible.

Right. Martin

comment:3 Changed 10 years ago by martinl

Owner: changed from warmerdam to martinl
Status: newassigned

comment:4 Changed 10 years ago by martinl

Cc: martinl removed

comment:5 Changed 10 years ago by Even Rouault

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.