Opened 14 years ago
Closed 14 years ago
#3317 closed enhancement (fixed)
Patch enabling copy operations for VFKProperty class
Reported by: | Mateusz Łoskot | Owned by: | martinl |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | OGR_SF | Version: | svn-trunk |
Severity: | normal | Keywords: | vfk |
Cc: |
Description
This patch implements copy constructor and assignment operator for VFKProperty class. This addition makes it possible to replace manually allocated and managed list of properties
VFKProperty **m_papszProperty;
with std::vector in VFKFeature class. It simplifies implementation removing code and gets rid of allocation of each property on heap. The patch does not apply any other changes to public interace of the two classes.
The patch also includes some trivial improvements to naming style.
Note, there is number of other places where similar improvements are possible.
Attachments (1)
Change History (6)
by , 14 years ago
Attachment: | ogr-vfk-vfkproperty-copyable.patch added |
---|
comment:2 by , 14 years ago
Replying to mloskot:
This patch implements copy constructor and assignment operator for VFKProperty class. This addition makes it possible to replace manually allocated and managed list of properties
patch applied in r18509, thanks.
Note, there is number of other places where similar improvements are possible.
Right. Martin
comment:3 by , 14 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:4 by , 14 years ago
Cc: | removed |
---|
comment:5 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Patch making VFKProperty copyable and replaces manual list with std::vector