patch to add projection file support to lcpdataset.cpp.

[Kyle Shannon]

Add the functionality for a lcpdataset to look for and load a spatial reference to a farsite landscape file. This was implemented the same way as it is in the AAIGrid driver.

[Even Rouault]

Kyle,

would you mind providing a link to a downloadable dataset that uses a .prj so that we can test your change ?

Also it would be far easier to review if your patch only contained the semantic changes, not all those whitespaces changes...

[Kyle Shannon]

better diff file

[Kyle Shannon]

Sorry about the diff file, it's my first patch. I think I got a better one up there. Also you can download this small lcp file with a prj file in a zip archive here: ​http://www.smoke-fire.us/trac/kyle/export/75/lcp_driver/test_lcp.zip

Let me know if I can do anything else. Thanks.

[Even Rouault]

The patch looks much better. Thanks. However I can't access your link. It asks me a login / password. I tried anonymous but it didn't work. If it's small enough, you could try attaching it to this ticket. Otherwise you can try to my email : even dot rouault at mines dash paris dot org.

[Kyle Shannon]

Replying to rouault:

The patch looks much better. Thanks. However I can't access your link. It asks me a login / password. I tried anonymous but it didn't work. If it's small enough, you could try attaching it to this ticket. Otherwise you can try to my email : even dot rouault at mines dash paris dot org.

Just attached the zip archive.

[Even Rouault]

I've attached a revised version of the patch because I noticed you've copied&pasted stuff that isn't really used. The poDS->adfGeoTransform array which existed before your wasn't used as the GetGeoTransform() method doesn't use it. So I've removed all its use as well as the OSR_GDS() function. It was probably something specific to the AAIGrid driver that doesn't make sense for LCP ? I've also fixed the missing initialization of pszProjection and it's deallocation.

Could you confirm that this version is OK ? (it gives identical results as your version on your sample)

[Even Rouault]

Revised version by Even Rouault

[Kyle Shannon]

I patched my source and everything worked well over here. Thanks for the help.

[Even Rouault]

Patch commited in trunk in r18123

[Kyle Shannon]

Even, should we add a prj to the autotest data directory at some point for testing this patch?

[warmerdam]

Even, see previous comment.

[Even Rouault]

Test updated in r18206

[Kyle Shannon]

Replying to rouault:

Test updated in r18206

Thanks Even

[Kyle Shannon]

Re-opening as I found a couple issues with the feature. 1) pszProjection was initialized to NULL, so GetProjectionRef() returned NULL if no prj was found. 2) Initializing pszProjection to non-NULL ("") caused the prj file to be added to the sibling list even if it didn't exist.

I have a fix, just going to do a bit of testing before I submit.

[Kyle Shannon]

Taking ownership.

[Kyle Shannon]

Fixed in trunk r26206 and branches/1.10 r26207.

[Even Rouault]

Kyle,

I believe this will leak memory. You should likely CPLFree(poDS->pszProjection); just before oSRS.exportToWkt( &(poDS->pszProjection) ); Other solution you keep the null initialization of pszProjection, and in GetProjectionRef() you return pszProjection ? pszProjection : ""

[Even Rouault]

Nevermind. I missed the commits r26209 and r26210

[Kyle Shannon]

I eventually remembered, :). I knew I forgot something.