#3231 closed defect (fixed)
WKT Raster driver: FIXME. nodata is always read as a double
Reported by: | jorgearevalo | Owned by: | jorgearevalo |
---|---|---|---|
Priority: | high | Milestone: | 1.7.0 |
Component: | GDAL_Raster | Version: | svn-trunk |
Severity: | normal | Keywords: | postgis_raster |
Cc: |
Description
When reading nodata from database, we always get a double. Doesn't make sense to fetch less than 8 bytes.
See http://trac.osgeo.org/gdal/browser/trunk/gdal/frmts/wktraster/wktrasterwrapper.cpp#L257
Change History (11)
comment:1 by , 14 years ago
Status: | new → assigned |
---|
comment:2 by , 14 years ago
Resolution: | → invalid |
---|---|
Status: | assigned → closed |
comment:3 by , 14 years ago
Resolution: | invalid |
---|---|
Status: | closed → reopened |
Ok, I was wrong. I reopen the ticket.
comment:4 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:5 by , 14 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Jorge,
several points :
- it would be good if you could improve your commit messages. "Ticket XXX closed" is not descriptive enough of what the change is. I must open the ticket to actually see what it is about. I'd suggest something like "WKTRaster: always read nodata as double (#3231)"
- when you close a ticket, it is also good to make a reference to the commit that fixed it in a comment. Like "fixed in trunk in r18163". That way we have full tracability between the ticket and the commit.
- last one : in r18163, you've commited - I guess - undesirable changes in aclocal.m4 and configure. Could you please revert them ? Thanks
comment:6 by , 14 years ago
Ok Even. I realized on the error with configure and aclocal.m4, but I couldn't solve at that moment. Sorry and thanks for the tips!
follow-up: 8 comment:7 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
The aclocal.m4 and configure files were restored. May I close this ticket?
comment:8 by , 14 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Replying to jorgearevalo:
The aclocal.m4 and configure files were restored. May I close this ticket
follow-up: 10 comment:9 by , 14 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Yes, that's fine. You don't need my confirmation when you are confident that things have been properly adressed. If I'm still unhappy, I'll reopen ;-)
comment:10 by , 14 years ago
Replying to rouault:
Yes, that's fine. You don't need my confirmation when you are confident that things have been properly adressed. If I'm still unhappy, I'll reopen ;-)
Understood :-)
comment:11 by , 12 years ago
Keywords: | postgis_raster added; wkt removed |
---|
I close this ticket. I forgot what spec says:
Nodata value: 1 to 8 bytes depending on pixtype.
So, I think is correct to read 1-8 bytes depending on pixeltype.