Opened 14 years ago
Closed 13 years ago
#3159 closed enhancement (fixed)
[PATCH] Adding support for new Ingres Geospatial
| Reported by: | atrofast | Owned by: | warmerdam |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.8.0 |
| Component: | OGR_SF | Version: | svn-trunk |
| Severity: | normal | Keywords: | ingres, ogr |
| Cc: |
Description
This patch will add support for the new Ingres Geospatial library. It uses WKB to retrieve and insert data.
Attachments (4)
Change History (10)
by , 14 years ago
| Attachment: | wkb-ogr.diff added |
|---|
comment:1 by , 14 years ago
| Summary: | Adding support for new Ingres Geospatial → [PATCH] Adding support for new Ingres Geospatial |
|---|
comment:2 by , 13 years ago
| Milestone: | → 1.7.0 |
|---|---|
| Status: | new → assigned |
by , 13 years ago
| Attachment: | new_ingres_support.diff added |
|---|
comment:3 by , 13 years ago
I had really wanted to test this in action, but I have not found the time to do so. I am applying it as is in trunk (r18518). It is in time for GDAL/OGR 1.7.0beta2.
I'll leave this ticket open till someone has had a chance to try it out.
comment:4 by , 13 years ago
I'm adding a patch that adds Spatial Reference System support for the OGR Ingres driver now that the new Ingres Geospatial supports it.
by , 13 years ago
| Attachment: | srs-ingres.diff added |
|---|
by , 13 years ago
| Attachment: | ogr_Close.diff added |
|---|
Fixes a potential double free, includes the diffs of the previous patch.
comment:5 by , 13 years ago
The ogr_Close.diff patch added takes care of a potential double free which caused a crash. This patch also contains the srs-ingres.diff changes as well so only this one is necessary. Thanks.
comment:6 by , 13 years ago
| Milestone: | 1.7.0 → 1.8.0 |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
I have applied slight variations on srs-ingres.diff and ogr_Close.diff in trunk (r19509) and tested them. Looking good! We might need want a more graceful response to the situation where the user does not have permission to extend the spatial_ref_sys table - perhaps using -1?
Alex, is this patch still current? I am planning to integrate it into trunk this week.