GDALWriteWorldFile : NULL to derive world-file extension from the pszBaseFilename crashes

[gislab]

Documentation says (​http://www.gdal.org/gdal_8h.html#dae2ed5807e4ec288812b54c6fccda1e), that it is possible to pass NULL to GDALReadWorldFile to derive it from the filename. Seems like this is not the case for GDALWriteWorldFile (no docs) and passing NULL crashes GDAL.

May be adding something like this would help:

if (pszExtension != NULL)

pszTFW = CPLResetExtension( pszBaseFilename, pszExtension );

else

pszTFW = pszBaseFilename;

-Maxim

[Even Rouault]

In r15744, I've added doc for GDALWriteWorldFile to specify that pszExtension must not be NULL. VALIDATE_POINTER1 also added to check it.

[gislab]

Replying to rouault:

In r15744, I've added doc for GDALWriteWorldFile to specify that pszExtension must not be NULL.

Thanks for working on that. Why not allow it to be NULL to generate world filename extension based on raster extension?

[Even Rouault]

Because there are many possible extensions depending on the use. For the read case we can try different patterns (for example for a PNG raster : wld, pgw, pngw), but for the write case, the user must specify the one that he really wants.