Opened 14 years ago

Closed 14 years ago

#2663 closed defect (fixed)

Change Gauss Laborde Reunion to Gauss Schreiber Transverse Mercator according to PROJ4.6.1

Reported by: dgrichard Owned by: warmerdam
Priority: high Milestone: 1.6.0
Component: OGR_SRS Version: unspecified
Severity: blocker Keywords:
Cc:

Description

As PROJ4.6.1 provides gstmerc in replacement of glabsgm, GDAL 1.6.0 needs to be updated.

Attachments (6)

ogr_srs_api.h.diff (1.4 KB ) - added by dgrichard 14 years ago.
ogr_spatialref.h.diff (969 bytes ) - added by dgrichard 14 years ago.
ogr_srs_proj4.cpp.diff (1.8 KB ) - added by dgrichard 14 years ago.
ogrspatialreference.cpp.diff (2.3 KB ) - added by dgrichard 14 years ago.
geoconcept_syscoord.c.diff (1.8 KB ) - added by dgrichard 14 years ago.
ors.i.diff (1.3 KB ) - added by dgrichard 14 years ago.

Download all attachments as: .zip

Change History (10)

by dgrichard, 14 years ago

Attachment: ogr_srs_api.h.diff added

by dgrichard, 14 years ago

Attachment: ogr_spatialref.h.diff added

by dgrichard, 14 years ago

Attachment: ogr_srs_proj4.cpp.diff added

by dgrichard, 14 years ago

by dgrichard, 14 years ago

Attachment: geoconcept_syscoord.c.diff added

by dgrichard, 14 years ago

Attachment: ors.i.diff added

comment:1 by Even Rouault, 14 years ago

Severity: normalblocker

Frank, Didier,

I'm a bit lost and worried by this ticket that replaces Gauss Laborde Reunion that was introduced during 1.6.0 developement (see #2134, r13482 and in r13487) by Gauss Schreiber.

I'm elevating the severity to blocker as we presumably cannot remove projections added in 1.6.0 in later versions. So we must decide *NOW* if we apply those patches, or otherwise we'll have to keep Gauss Laborde Reunion later.

in reply to:  1 comment:2 by dgrichard, 14 years ago

Replying to rouault:

Frank, Didier,

I'm a bit lost and worried by this ticket that replaces Gauss Laborde Reunion that was introduced during 1.6.0 developement (see #2134, r13482 and in r13487) by Gauss Schreiber.

You're right #2134 was the first place I put these changes. Few days ago, I commited them to the trunk (just before the 1.6.0beta1) along with other changes. My commit was reverted by Frank because of too many impacts on the trunk. Frank suggested me to propose tickets for Gauss Schreiber and GTiff (See #2664) between beta1 and beta2 and decide whether or not take them into account (specially for GTiff). That's what I did.

I'm elevating the severity to blocker as we presumably cannot remove projections added in 1.6.0 in later versions. So we must decide *NOW* if we apply those patches, or otherwise we'll have to keep Gauss Laborde Reunion later.

It would be better to switch Gauss Laborde to Gauss Schreiber before the finalisation of 1.6.0.

comment:3 by Even Rouault, 14 years ago

Priority: normalhigh

comment:4 by Even Rouault, 14 years ago

Resolution: fixed
Status: newclosed

ok, I finally understood what happened by looking closely at the history of proj4 (really nice that it is under trac now to follow history of changes) : glabsgm was first introduced and then replaced by gstmerc (by the way, the NEWS in proj 4.6.1 is a bit confusing as it gives the impression that glabsgm is also supported)

I've commited the series of patches in r15742, with a slight modification (removing '+dfFromGreenwich' in ogr_srs_proj4.cpp as it was removed a few months ago for all projections in r12535), and addition of the validation of gstmerc in ogr_srs_validate.cpp

Note: See TracTickets for help on using tickets.