egif_lib error on 64-bit/RHEL 5

[jccartwright]

I was unable to compile 1.4.2 on a RHEL 5/64-bit system, getting an error:

libungif/egif_lib.c: In function 'EGifOpenFileName': libungif/egif_lib.c:79: error: 'S_IREAD' undeclared (first use in this function) libungif/egif_lib.c:79: error: (Each undeclared identifier is reported only once libungif/egif_lib.c:79: error: for each function it appears in.) libungif/egif_lib.c:79: error: 'S_IWRITE' undeclared (first use in this function)

Frank supplied a file http://trac.osgeo.org/gdal/browser/trunk/gdal/frmts/gif/libungif/egif_lib.c?format=raw

that seemed to fix the problem. Can this be migrated into the 1.4.x branch?

Thanks!

--john

[warmerdam]

I have migrated this change into 1.4.x. I basically added the following:

#if !defined(S_IREAD) && defined(S_IRUSR)
#  define S_IREAD  S_IRUSR
#  define S_IWRITE S_IRUSR
#endif

I get the impression that S_IREAD and S_WRITE are not the standardized name. Of course this change will be lost next time we upgrade libungif.