Opened 15 years ago

Closed 6 years ago

#1209 closed defect (fixed)

incorrect MapInfo style string causes system exception

Reported by: richard.matsunaga@… Owned by: warmerdam
Priority: normal Milestone:
Component: OGR_SF Version: unspecified
Severity: normal Keywords: mitab
Cc:

Description (last modified by Jukka Rahkonen)

Upon creating a new feature on a MapInfo layer, if the style string in the
feature is invalid, the MapInfo driver will throw an exception instead of
reporting an error.

For example, the following string is only invalid by an extra space character
after the comma:

"SYMBOL(c:#000000, id:\"ogr-sym-1\")"

and will cause a crash on the OGR_L_CreateFeature() call.

Attachments (1)

ogr_style_error.jml (1.3 KB) - added by Jukka Rahkonen 7 years ago.

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by Jukka Rahkonen

Attachment: ogr_style_error.jml added

comment:1 Changed 7 years ago by Jukka Rahkonen

Description: modified (diff)

I can reproduce the error with attached OpenJUMP file which has a faulty style string

SIMBOL(c:#000000, id:\"ogr-sym-1\")

System tolerates extra spaces nowadays so I had to introduce a bigger error.

Command "ogr2ogr -f "mapinfo file" ogrstyle.mif ogr_style_error.jml" makes ogr2ogr.exe to crash on Windows 7 without any error messages.

Tested with GDAL 2.0-dev

comment:2 Changed 7 years ago by Jukka Rahkonen

Keywords: mitab added

comment:3 Changed 7 years ago by Even Rouault

trunk r28313, branches/1.11 r28314 "MITAB: fix segfault in CreateFeature?() if passing an invalid OGR feature style string (#1209)"

comment:4 Changed 7 years ago by Jukka Rahkonen

If this is advertized as fixed in http://trac.osgeo.org/gdal/wiki/Release/1.11.2-News?version=1, is the ticket mature enough for closing?

comment:5 in reply to:  4 Changed 7 years ago by Even Rouault

Replying to jratike80:

If this is advertized as fixed in http://trac.osgeo.org/gdal/wiki/Release/1.11.2-News?version=1, is the ticket mature enough for closing?

This is just because it is is a mitab issue.

comment:6 Changed 6 years ago by Even Rouault

Priority: highnormal

All those tickets have more than one year and nobody has acted on it, so the priority is not so high

comment:7 Changed 6 years ago by Even Rouault

Resolution: fixed
Status: newclosed

Batch closing of MITAB tickets fixed in GDAL. They were kept open because not merged into MITAB separate repository, but the latter one is inactive, so let's close them definitely.

Note: See TracTickets for help on using tickets.