Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#664 closed defect (fixed)

Re-instate Google Maps script appending client-side

Reported by: jng Owned by: jng
Priority: P2 Milestone: Future
Component: Widgets Version: 2.0
Severity: Major Keywords:
Cc: Browser: All
External ID: Operating System: All
state: New

Description

Although the unified entry point work removed loading Google Maps script tags client-side, upon second thought: It is possible to "safely" load Google Maps on the client-side (don't document.write the script tags, rather document.createElement the required script tags just like we do for the widgets).

This way, we don't need to force a breaking migration change to the new unified entry point and existing users can still remain on the index.html entry point.

Change History (2)

comment:1 by jng, 6 years ago

Resolution: fixed
Status: assignedclosed

In 3047:

Re-instate client-side Google Maps script loading. It slipped my mind when I removed the client-side loading that we can actually do this in a "safe" manner.

We just document.createElement() the script tag instead of document.write()'ing it. This is what we're doing for the widget scripts.

As part of this change, several synchronous XHR requests we were making have been converted to async as well.

Fixes #664

comment:2 by jng, 6 years ago

In 3048:

Merged revision(s) 3047 from trunk:
Re-instate client-side Google Maps script loading. It slipped my mind when I removed the client-side loading that we can actually do this in a "safe" manner.

We just document.createElement() the script tag instead of document.write()'ing it. This is what we're doing for the widget scripts.

As part of this change, several synchronous XHR requests we were making have been converted to async as well.

Fixes #664
........

Note: See TracTickets for help on using tickets.